New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: don't connect socket if SOCKET_SERVER is set to none #370

Merged

sorrycc merged 1 commit into master from feat/socket

Apr 24, 2018

Member

sorrycc commented Apr 24, 2018 •

edited

Loading

Close #365


          feat: don't connect socket if SOCKET_SERVER is set to none

555ba9b

sorrycc added the type(enhancement) label

coveralls commented Apr 24, 2018

Pull Request Test Coverage Report for Build 225

0 of 22 (0.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 4.752%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/af-webpack/src/patchConnection.js	0	7	0.0%
packages/af-webpack/src/webpackHotDevClient.js	0	15	0.0%

Totals
Change from base Build 221:	-0.01%
Covered Lines:	81
Relevant Lines:	1726

💛 - Coveralls

1 similar comment

coveralls commented Apr 24, 2018

Pull Request Test Coverage Report for Build 225

0 of 22 (0.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 4.752%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/af-webpack/src/patchConnection.js	0	7	0.0%
packages/af-webpack/src/webpackHotDevClient.js	0	15	0.0%

Totals
Change from base Build 221:	-0.01%
Covered Lines:	81
Relevant Lines:	1726

💛 - Coveralls

sorrycc merged commit d02c52b into master

sorrycc deleted the feat/socket branch

April 24, 2018 06:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type(enhancement)