Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refact(umi-build-dev): HtmlGenerator #437

Merged
merged 5 commits into from
May 8, 2018
Merged

refact(umi-build-dev): HtmlGenerator #437

merged 5 commits into from
May 8, 2018

Conversation

sorrycc
Copy link
Member

@sorrycc sorrycc commented May 8, 2018

No description provided.

@coveralls
Copy link

coveralls commented May 8, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 343

  • 64 of 92 (69.57%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+10.1%) to 19.369%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/umi-build-dev/src/Compiling.js 0 1 0.0%
packages/umi-build-dev/src/Service.js 0 1 0.0%
packages/umi-build-dev/src/html/getHTMLContent.js 49 51 96.08%
packages/umi-build-dev/src/middlewares/createRouteMiddleware.js 0 7 0.0%
packages/umi-build-dev/src/html/HtmlGenerator.js 11 28 39.29%
Totals Coverage Status
Change from base Build 333: 10.1%
Covered Lines: 399
Relevant Lines: 2315
💛 - Coveralls

@sorrycc sorrycc merged commit e4a55fa into master May 8, 2018
@sorrycc sorrycc deleted the refact/HtmlGenerator branch May 8, 2018 03:42
@xiaohuoni xiaohuoni mentioned this pull request May 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type(enhancement)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sorrycc @coveralls