Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: compatible with bigfish's routes via BIGFISH_COMPAT #564

Merged
merged 2 commits into from
May 30, 2018
Merged

feat: compatible with bigfish's routes via BIGFISH_COMPAT #564

merged 2 commits into from
May 30, 2018

Conversation

sorrycc
Copy link
Member

@sorrycc sorrycc commented May 30, 2018

props.params = props.match.params

@coveralls
Copy link

coveralls commented May 30, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 526

  • 14 of 18 (77.78%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 21.365%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/umi/src/renderRoutes.js 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
packages/umi/src/renderRoutes.js 1 0.0%
Totals Coverage Status
Change from base Build 519: -0.005%
Covered Lines: 509
Relevant Lines: 2596
💛 - Coveralls

@sorrycc sorrycc merged commit 6376847 into master May 30, 2018
@sorrycc sorrycc deleted the feat/compat-bigfish branch June 27, 2018 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type(enhancement)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sorrycc @coveralls