Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: af-webpack should resolve eslintrc according to APP_ROOT #642

Merged
merged 1 commit into from
Jun 20, 2018

Conversation

paranoidjk
Copy link
Contributor

Problem

when exec "APP_ROOT=yunfengdie/app/assets umi build" in egg, af-webpack still look eslintrc in /.eslintrc, which should be /yunfengdie/app/assets/.eslintrc

should resolve eslintrc according to APP_ROOT
@paranoidjk
Copy link
Contributor Author

cc/ @sorrycc

@coveralls
Copy link

Pull Request Test Coverage Report for Build 677

  • 2 of 5 (40.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 22.243%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/af-webpack/src/getConfig.js 2 5 40.0%
Totals Coverage Status
Change from base Build 675: 0.02%
Covered Lines: 527
Relevant Lines: 2608

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 677

  • 2 of 5 (40.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 22.243%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/af-webpack/src/getConfig.js 2 5 40.0%
Totals Coverage Status
Change from base Build 675: 0.02%
Covered Lines: 527
Relevant Lines: 2608

💛 - Coveralls

@sorrycc sorrycc merged commit 743faa0 into umijs:master Jun 20, 2018
@paranoidjk paranoidjk deleted the fix-eslintrc branch June 20, 2018 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants