-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: qiankun slave no render #9806
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Size Change: 0 B Total Size: 9.97 MB ℹ️ View Unchanged
|
Codecov ReportBase: 29.15% // Head: 29.15% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #9806 +/- ##
=======================================
Coverage 29.15% 29.15%
=======================================
Files 429 429
Lines 12128 12128
Branches 2901 2901
=======================================
Hits 3536 3536
Misses 8031 8031
Partials 561 561 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
return qiankunRender().then(() => { | ||
// modifyContextOpts 调整到 render 之前执行,oldRender 应该在 qiankunRender 之后,子应用配置又是动态的,所以在这里取配置最合理 | ||
const clientRenderOpts = contextOptsStack.shift(); | ||
oldRender(clientRenderOpts); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
经过 #9765 调整之后,modifyContextOpts 调整到 render 之前执行,
在这里 oldRender 应该在 qiankunRender 之后,子应用配置又是动态的,所以 给 render 传递新的 config ,我觉得比较合理。