Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomise x, y vectors #1

Closed
brmather opened this issue May 9, 2017 · 1 comment
Closed

Randomise x, y vectors #1

brmather opened this issue May 9, 2017 · 1 comment

Comments

@brmather
Copy link
Member

brmather commented May 9, 2017

Points are randomised in create_DMPlex_from_points to improve triangulation performance, but this breaks some existing code in the notebooks. It can be easily fixed, but I'm not sure which is better...

  1. Put the permutation routine in the other mesh generation functions, and assume the x,y vectors are shuffled prior to making the DM.
  2. Have a convenience method get_xy in trimesh to return the shuffled (local) x,y vectors.

The second option might be wiser since refinement will add new points anyway.

@lmoresi
Copy link
Member

lmoresi commented May 9, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants