Create table to store EU entry and exit dates #894
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacug
requested changes
Oct 12, 2022
app/models/eu_country_status.rb
Outdated
Comment on lines
2
to
4
| attr_accessible :eu_accession_year, :eu_exit_year | ||
| belongs_to :geo_entity | ||
| validates :geo_entity, :presence => true |
There was a problem hiding this comment.
can we fix the indentation here, please?
app/models/eu_country_status.rb
Outdated
Comment on lines
2
to
4
| attr_accessible :eu_accession_year, :eu_exit_year | ||
| belongs_to :geo_entity | ||
| validates :geo_entity, :presence => true |
There was a problem hiding this comment.
I would also validate that the geoentity needs to be a country(geo_entity_type)
| @@ -0,0 +1,10 @@ | |||
| class CreateEuCountryStatuses < ActiveRecord::Migration | |||
There was a problem hiding this comment.
I'm not totally convinced by the name of this table, I would have gone with something like eu_country_dates maybe? let's have a chat about it
|
Changes are done. Thanks |
lucacug
requested changes
Oct 13, 2022
|
|
||
| private | ||
|
|
||
| def is_country |
There was a problem hiding this comment.
this doesn't seem to be used anywhere here, we might need to add a validate line
There was a problem hiding this comment.
oops!! forgot to add it. Added it now
Thanks
|
looks good now! Tagging as don't merge to use it as the feature branch of all this task |
…import-task EU accession exit date import task
lucacug
approved these changes
Oct 17, 2022
Merged
|
closing because superseded by this one #904 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
146