Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-14054 minimumdigitgrouping for es-419, es-US & es-MX #1008

Closed
wants to merge 3 commits into from

Conversation

AEApple
Copy link
Contributor

@AEApple AEApple commented Feb 3, 2021

Update minimumdigitgrouping for es-419, es-US & es-MX per language specialist feedback that Spanish in Latin America uses minimum digit grouping of 1.

I have updated the two other Latin America Spanish variants since our language specialist confirmed that minimum grouping should be 1 for all Latin American Spanish locales, but let me know if you are concerned and I can update the PR. I will update the ticket with sources for each country to demonstrate usage.

Checklist

Change minimum digit grouping for es_419 from 2 to 1
Update minimum digit grouping for es_MX
Update minimum digit grouping for es_US from 2 to 1
@stenshamn
Copy link
Contributor

Technically you could have removed the entry entirely in es_MX and es_US and it would have inherited from es_419, but I think this works too. @srl295 , what do you think?

@AEApple
Copy link
Contributor Author

AEApple commented Feb 3, 2021

The Maven checks are failing. How do I resolve this?

@pedberg-icu
Copy link
Contributor

The Maven checks are failing. How do I resolve this?

This needs to be (1) rebased onto latest master to pick up a fix from another recent PR, and (2) squashed. The fastest way to do this for now is just to create another PR based on latest master. I have done this in #1009 so I will close this one and we can use that one instead.

@pedberg-icu pedberg-icu closed this Feb 4, 2021
@pedberg-icu
Copy link
Contributor

Technically you could have removed the entry entirely in es_MX and es_US and it would have inherited from es_419, but I think this works too. @srl295 , what do you think?

It is fine to leave them here for now, they will likely be removed when we do locale minimization

@AEApple AEApple deleted the CLDR-14054-es_419-minimumdigitgrouping branch July 21, 2021 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants