Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3.2 branch #4107

Closed
wants to merge 5 commits into from
Closed

1.3.2 branch #4107

wants to merge 5 commits into from

Conversation

robertbastian
Copy link
Member

No description provided.

@Manishearth
Copy link
Member

r=me for releasing. once released we plan to tag this but not merge it

@Manishearth
Copy link
Member

The parent commit here is 713c90e

@Manishearth
Copy link
Member

Wait, no, not r=me, we should include the doc patches

@robertbastian
Copy link
Member Author

cherry-picked

@Manishearth
Copy link
Member

Manishearth commented Oct 3, 2023

ty. r=me, will start publishing soon (commit ac39015)

crates to publish:

  • tinystr
  • all components/provider/experimental components
  • datagen/capi

@robertbastian
Copy link
Member Author

You should just do cargo ws publish --from-git. I've bumped the global version, so we should release all crates that use that.

Also testdata

@Manishearth
Copy link
Member

I still don't trust magical tools that publish everything for you, especially if we need to wait with a manual step.

Also I wanted to parallelize, which I've been succeeding at.

@Manishearth
Copy link
Member

Everything except datagen and testdata is released and tagged. @robertbastian what should I do for testdata?

@Manishearth
Copy link
Member

I guess I just run testdata-legacy and then publish testdata

@Manishearth
Copy link
Member

Let's leave this PR open and unmerged and merge a separate PR that contains your 132 commit onto main so that main reflects the correct versions

@robertbastian
Copy link
Member Author

The 132 commit conflicts with main

@Manishearth
Copy link
Member

All published

@Manishearth
Copy link
Member

4108

@robertbastian robertbastian deleted the 132 branch October 4, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants