This repository has been archived by the owner on Jul 19, 2022. It is now read-only.
Separate apps: Unison Share & Unison Local #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hojberg
force-pushed
the
separate-apps
branch
from
baddff0
to
d04433b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As the 2 apps housed within this codebase becomes more and more separate in functionality we want there to be a clean separate between them and allow for shared code to exist on a different level.
To further this, duplicate the App module (with minor modifications to remove app context aware code) between UnisonLocal and UnisonShare. Right now there's a lot of duplication there, but this will be teased apart over time. Most of what is done in App should likely be done by a sub page handler.
This is part of the effort to add a new from page to Unison Share, tracked here: #144