This repository has been archived by the owner on Jul 19, 2022. It is now read-only.
Add Catalog Route and render Catalog page #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hojberg
commented
Dec 13, 2021
| @@ -9,7 +9,7 @@ | |||
| "scripts": { | |||
| "build": "webpack --mode production --config webpack.prod.js", | |||
| "clean": "rm -rf dist", | |||
| "start": "webpack serve --mode development --port 1234 --config webpack.dev.js", | |||
| "start": "echo 'Please use either `npm run start:unisonLocal` or `npm run start:unisonShare`'", | |||
There was a problem hiding this comment.
npm start is no longer used.
Add a new Catalog Route to render the Catalog page on /catalog (this is intended to eventually be the front page of Unison Share)
hojberg
force-pushed
the
catalog-route
branch
from
2b9e0d2
to
00fdbbd
Compare
hojberg
commented
Dec 13, 2021
| , toRoute | ||
| , toUrlString | ||
| , updatePerspectiveParams | ||
| ) |
There was a problem hiding this comment.
This is pretty much the old route, now duplicated between UnisonLocal and UnisonShare. The main difference (for right now) is that the UnisonShare.Route has a Catalog variant
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add a new Catalog Route to render the Catalog page on /catalog (this is
intended to eventually be the front page of Unison Share)