This repository has been archived by the owner on Jul 19, 2022. It is now read-only.
Move AppHeader back up to App #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AppHeader has App specifics, not Page specifics and should not be part of a PageLayout.
hojberg
force-pushed
the
move-app-header-to-app
branch
from
be8e9e4
to
aa127fe
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The AppHeader has App specifics, not Page specifics and should not be part of a PageLayout.
This prevents us from correctly hooking up interactivity on pages like Catalog, due to the types of Msg being mixed.
Solution
Move AppHeader back up to App and improve the css slightly such that sidebar styling goes in page-layout (should perhaps be in a separate module in a later sidebar cleanup effort)