Skip to content

Add PAT support #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 1, 2022
Merged

Add PAT support #17

merged 5 commits into from
Dec 1, 2022

Conversation

unixorn
Copy link
Owner

@unixorn unixorn commented Dec 1, 2022

  • Update cryptography version to include security update.
  • Support PAT and OAUTH in addition to Basic Authentication.
  • Move linkIssuesHack() into the JiraTool class to make it easier to get at the embedded Jira object so we can tailgate into Jira with its authentication credentials.
  • Delete all the inline oauth code we were using before realizing we could just borrow the authentication data from the Jira object.
  • Formatting cleanups.
  • Add labeling to generated docker images so that the docker image includes the module version in its metadata

Signed-off-by: Joe Block <jblock@zscaler.com>
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
❌ DOCKERFILE hadolint 1 1 0.09s
❌ MAKEFILE checkmake 1 1 0.0s
✅ PYTHON bandit 3 0 1.33s
✅ PYTHON black 3 0 1.19s
✅ PYTHON flake8 3 0 0.7s
❌ PYTHON pylint 3 4 3.11s
❌ PYTHON pyright 3 17 7.76s
✅ REPOSITORY devskim yes no 0.7s
✅ REPOSITORY dustilock yes no 0.0s
✅ REPOSITORY gitleaks yes no 0.18s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 1.06s
✅ REPOSITORY syft yes no 0.44s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Support PAT and OAUTH in addition to Basic Authentication.

- Move `linkIssuesHack()` into the `JiraTool` class to make it easier
  to get at the embedded `Jira` object so we can tailgate into Jira with
  its authentication credentials.
- Delete all the inline oauth code we were using before realizing we
  could just borrow the authentication data from the Jira object.
- Formatting cleanups.

Signed-off-by: Joe Block <jblock@zscaler.com>
Signed-off-by: Joe Block <jblock@zscaler.com>
Update Dockerfile and Makefile to label images with the `jira-commands`
module version.

Signed-off-by: Joe Block <jblock@zscaler.com>
Signed-off-by: Joe Block <jblock@zscaler.com>
@unixorn unixorn merged commit 4bff98a into main Dec 1, 2022
@unixorn unixorn deleted the add-PAT-support branch December 1, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant