feat(idux): update idux resolver to support v2 version #722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sallerli1
force-pushed
the
feat-idux-resolver-v2
branch
from
5d29c10 to
189da5f
Compare
|
@antfu can u please review this pr? |
This was referenced May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we recently published beta version of Idux v2, and we changed our theme and style import methods, original resolve wouldn't correctly import style and theme assets of v2 version components.
Linked Issues
fix #721
Additional context
I added a version configuration to the options of the resolver which is auto detected by
local-packageby defaultoriginal side effects resolve method is moved to
getLegacySideEffects