Upgrade crossplane-runtime #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toastwaffle
requested review from
bobh66,
ytsarev,
negz,
ulucinar,
sergenyalcin and
turkenf
as code owners
|
|
|
/test-examples="examples/workspace-inline-aws.yaml" |
|
Any update on this ? |
|
Hi @toastwaffle thanks for the contribution! I agree the changes are related but I feel like this is a lot in one PR and it would be better to separate them. It will make it easier to test as well. Thanks! |
toastwaffle
changed the title
|
@bobh66 done :) I'll send another PR to add jitter once this one is landed. |
|
/test-examples="examples/workspace-inline-aws.yaml" |
ytsarev
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
This looks great. @toastwaffle thanks a lot for the contribution!
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR unblocks adding support for jitter in the poll interval.
crossplane-runtimehas been updated to the same (unreleased) version currently used by provider-gcp. This includes some breaking changes (as provider-terraform was actually quite far behind the latest version, released or otherwise):ProviderReferencefield entirelyI have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Ran
make test. I was hoping to use uptest, but it's not clear whether there are any valid tests? If not, I can try to do some manual testing.