Skip to content
This repository has been archived by the owner on Aug 9, 2024. It is now read-only.

Warn when logging buffer is full #103

Closed
stephane-caron opened this issue May 29, 2024 · 0 comments
Closed

Warn when logging buffer is full #103

stephane-caron opened this issue May 29, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@stephane-caron
Copy link
Member

stephane-caron commented May 29, 2024

As discussed with @ubgk today, currently we don't check that logging succeeds at every spine cycle:

logger_.put(working_dict_);

The output from mpacklog::Logger::put is a success boolean. When it fails we should warn users that some log entries are being lost. (Perhaps suggest follow-up actions such as (1) increasing the size of the circular buffer or (2) reducing the size of logged dictionaries.)

@stephane-caron stephane-caron changed the title Log when circular buffer is full Warn when logging buffer is full May 29, 2024
stephane-caron added a commit that referenced this issue Jun 18, 2024
@stephane-caron stephane-caron added the enhancement New feature or request label Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant