Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing strategy is not portable to windows #121

Closed
jameslamb opened this issue Nov 6, 2018 · 1 comment
Closed

testing strategy is not portable to windows #121

jameslamb opened this issue Nov 6, 2018 · 1 comment
Assignees
Labels

Comments

@jameslamb
Copy link
Member

@jameslamb jameslamb commented Nov 6, 2018

As of #108 , we added a bunch of new stuff to make our code testable on CRAN.

To make forward progress on the issues faced in that PR, we made a choice to use an approach that is Linux-specific (calling which -a R).

Addressing this issue means replacing this: https://github.com/UptakeOpenSource/pkgnet/blob/master/R/testing_utils.R#L46 or wrapping it in some kind of if-else statement of the form

if (ON UNIX_ALIKE){
    R_LOC <- system("which -a R", intern = TRUE)
    R_LOC <- R_LOC[!grepl("R_check_bin", R_LOC)][1]
} else {
    other_stuff()
}
@jameslamb
Copy link
Member Author

@jameslamb jameslamb commented Nov 7, 2018

more proof from devtools::build_win():

image

https://win-builder.r-project.org/yHIi38dYz5RI/00check.log

@bburns632 bburns632 added this to the Release v0.3.0 milestone Nov 16, 2018
@jameslamb jameslamb self-assigned this Nov 24, 2018
jameslamb added a commit to jameslamb/pkgnet that referenced this issue Nov 26, 2018
@jayqi jayqi closed this in #139 Nov 27, 2018
jayqi added a commit that referenced this issue Nov 27, 2018
made testing strategy portable (fixes #121)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.