-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android in-app looks like IOS banner #151
Comments
@Hema2810 : Banner messages can be placed at the top or the bottom of the screen. They are not intended to float on the screen as do Android snackbars or toasts. You might look at Modal messages, which appear in the middle of the screen. |
@BrianBatchelder Yes I need them on the top and bottom of the screen. But when you look
at the documentation the default presentation is different from that of
IOS. Is there a way to get it without custom implementation. Refer to the image I posted below from the document
…On Tue, May 12, 2020, 6:00 PM Brian Batchelder ***@***.***> wrote:
@Hema2810 <https://github.com/Hema2810> : Banner messages can be placed
at the top or the bottom of the screen. They are not intended to float on
the screen as do Android snackbars or toasts. You might look at Modal
messages
<https://docs.airship.com/reference/messages/message-types/in-app-messages/#style-modal>,
which appear in the middle of the screen.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#151 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHNSVPLRXHU5KCE627VUHBDRRHIKNANCNFSM4M7HDSBA>
.
|
@Hema2810 : I'm re-opening this issue as I see now that the images of Android banner messages in the docs don't match what the SDK actually produces. I will get back to you soon about this. |
Turns out the images you are referring to are for our legacy "Standard In-App Messages", and, unfortunately, the images are also out-of-date. I'm afraid the only way for you to get the messages to appear like you want on Android is to implement a custom message adapter. In the meantime, we will update our documentation. Thank you for pointing it out. |
Thank you for the response. Another problem I noticed was that when the app uses transparent navigation bar, the in app message appear over it and there is no way to click on the message. There should at least be a way to display the message above the navigation bar, but I do not find any such option. |
and also these links do no work |
@BrianBatchelder considering the dashboard is not also updated, I would not consider this issue as closed. It creates quite a bit of confusion. From what I see ,there is no option but to go for custom for Android, which takes the "easy of use" out for Android. I would really appeal to the team to consider it for future release. Let me know if I need to open a new issue. |
@Hema2810 Thank you for all the feedback. We will update the docs and dashboard to match our current behavior (and fix the links). I will also look into the issue with transparent navigation bars. I will also pass along your request to provide a mechanism to display Android messages that look more like a snackbar. I'll keep this ticket open so we can notify you when we have updated the docs and dashboard. |
Thank you! Appreciate the quick response. |
I have been unable to reproduce this. In my testing, the message always appears in front of the navigation bar, and is clickable. Can you provide me with more details? |
Just to give an update, both apps use full screen. I do not have issue on older phones which have physical button and do not have navigation bar on the screen. Only on newer phones with the navigation bars on the screen. Especially in apps which use full screen with transparent/translucent, navigation bars/ status bars. |
@Hema2810 : could you provide the version(s) of Android on which you are seeing the navigation bar issue? Thanks. |
I see the issue on Android 10 on my pixel 3. Could be on other versions and device, but currently noticed on this, would have to test the others. |
@Hema2810 I was able to reproduce and fix your issue with the window insets on Android 10. Fix will go out in the next patch release. I will work on docs next. If you want the style sheets for the banner, it can be located here. We filed an issue with our web team about the outdated preview, and sent your feedback about the design to the product manager. I tried out making the banner into a card view, while keeping most if not all the style options for IAA. I am sure you could optimize the view based on your usage, but this reuses as much as I could from the SDK. layout/card_banner.xml
CardBannerView.kt:
CardBannerAdapter.kt:
In Autopilot, override the banner factory:
|
@rlepinski , thank you for the update. |
Fixed in 13.1.1 |
❗For how-to inquiries involving Airship functionality or use cases, please
contact (support)[https://support.airship.com/].
Preliminary Info
What Airship dependencies are you using?
What are the versions of any relevant development tools you are using?
Report
What unexpected behavior are you seeing?
According to this
https://docs.airship.com/reference/messages/message-types/in-app-messages/#style-banner
Android is supposed to receive the in- app messages which looks more like a snackbar, but the ones I receive look more like the IOS drawer.
What is the expected behavior?
Should receive the in-app message like it is specified in the document
What are the steps to reproduce the unexpected behavior?
Implement the sdk in any android project and send a in-app message
Do you have logging for the issue?
The text was updated successfully, but these errors were encountered: