Skip to content

Conversation

@dasmer
Copy link
Contributor

@dasmer dasmer commented Apr 22, 2015

  • Adds KIF to test the Class Based Route-Handler flow. It also increases test coverage to 95%.

Coverage Status

@dasmer
Copy link
Contributor Author

dasmer commented Apr 22, 2015

This also removes the TEST preprocessor macro since this test requires the DPLDeepLinkRouter setup in ReceiverDemo's Application Delegate. Definitely open to other ways around handling this. :octocat:

@coveralls
Copy link

Coverage Status

Coverage increased (+4.98%) to 94.79% when pulling 43ada91 on dasmer:master into a87c418 on usebutton:master.

@wessmith
Copy link
Member

Nice!! I'll have a look at this tomorrow.

@chrismaddern
Copy link
Contributor

This is awesome! Nice one man -- it's on the docket to look for more explicit ways to test deep links.. I think that will be a real differentiator

chrismaddern added a commit that referenced this pull request Apr 22, 2015
Add KIF to test Class Based Route-Handler. Bumps Test Coverage
@chrismaddern chrismaddern merged commit 265ea83 into button:master Apr 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants