Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: backup file rotate #2511

Merged
merged 1 commit into from
Nov 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 9 additions & 3 deletions server/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,11 @@ func NewServer(ctx context.Context, profile *profile.Profile, store *store.Store
Profile: profile,

// Asynchronous runners.
backupRunner: backup.NewBackupRunner(store),
telegramBot: telegram.NewBotWithHandler(integration.NewTelegramHandler(store)),
telegramBot: telegram.NewBotWithHandler(integration.NewTelegramHandler(store)),
}

if profile.Driver == "sqlite" {
s.backupRunner = backup.NewBackupRunner(store)
}

e.Use(middleware.LoggerWithConfig(middleware.LoggerConfig{
Expand Down Expand Up @@ -112,7 +115,10 @@ func NewServer(ctx context.Context, profile *profile.Profile, store *store.Store
func (s *Server) Start(ctx context.Context) error {
go versionchecker.NewVersionChecker(s.Store, s.Profile).Start(ctx)
go s.telegramBot.Start(ctx)
go s.backupRunner.Run(ctx)

if s.backupRunner != nil {
go s.backupRunner.Run(ctx)
}

metric.Enqueue("server start")
return s.e.Start(fmt.Sprintf("%s:%d", s.Profile.Addr, s.Profile.Port))
Expand Down
39 changes: 34 additions & 5 deletions server/service/backup/backup.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package backup
import (
"context"
"fmt"
"os"
"strconv"
"time"

Expand All @@ -24,6 +25,8 @@ func NewBackupRunner(store *store.Store) *BackupRunner {
}
}

const MaxBackupFiles = 5

func (r *BackupRunner) Run(ctx context.Context) {
intervalStr := r.Store.GetSystemSettingValueWithDefault(ctx, apiv1.SystemSettingAutoBackupIntervalName.String(), "")
if intervalStr == "" {
Expand All @@ -46,20 +49,46 @@ func (r *BackupRunner) Run(ctx context.Context) {
ticker := time.NewTicker(time.Duration(interval) * time.Second)
defer ticker.Stop()

var t time.Time
for {
select {
case <-ctx.Done():
log.Info("stop auto backup graceful.")
return
case t = <-ticker.C:
case <-ticker.C:
}

filename := r.Store.Profile.DSN + ".bak"

if err := rotateFiles(filename, MaxBackupFiles); err != nil {
log.Error("fail to rotate backup files", zap.Error(err))
continue
}

filename := r.Store.Profile.DSN + t.Format("-20060102-150405.bak")
log.Info(fmt.Sprintf("create backup to %s", filename))
err := r.Store.BackupTo(ctx, filename)
if err != nil {
if err := r.Store.BackupTo(ctx, filename); err != nil {
log.Error("fail to create backup", zap.Error(err))
}
}
}

func rotateFiles(filename string, cnt int) error {
// Generate suffix slices of history files like "",".1",".2",".3"...
ss := make([]string, cnt-1)
for i := 1; i < len(ss); i++ {
ss[i] = fmt.Sprintf(".%d", i)
}

// Iterate through the suffix slices and rename the files
for i := len(ss) - 1; i >= 0; i-- {
from := filename + ss[i]
to := filename + "." + strconv.Itoa(i+1)

log.Info("rotate file", zap.String("from", from), zap.String("to", to))
err := os.Rename(from, to)
if err != nil && !os.IsNotExist(err) {
return err
}
}

return nil
}