Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard deprecate Timestamp::to_unix_nanos #673

Merged
merged 2 commits into from
May 15, 2023
Merged

Conversation

KodrAus
Copy link
Member

@KodrAus KodrAus commented May 7, 2023

The Timestamp::to_unix method has been deprecated for some time now. I'd like to remove it entirely in a future release. I can't find any actual usages of it, since the method was never useful, so in a 2.x release of uuid it will disappear. Note that since the plan is for 1.x to re-export 2.x that means this method will vanish in some future minor release of 1.x. We don't want to do this often, but the alternative of letting multiple versions of the Uuid type float around is worse than having a single deprecated and useless method disappear.

@KodrAus KodrAus merged commit 534691e into main May 15, 2023
kodiakhq bot pushed a commit to pdylanross/fatigue that referenced this pull request May 15, 2023
Bumps uuid from 1.3.2 to 1.3.3.

Release notes
Sourced from uuid's releases.

1.3.3
What's Changed

Use sha hash for checkout action and remove others by @​KodrAus in uuid-rs/uuid#671
Hard deprecate Timestamp::to_unix_nanos by @​KodrAus in uuid-rs/uuid#673
Prepare for 1.3.3 release by @​KodrAus in uuid-rs/uuid#674

Full Changelog: uuid-rs/uuid@1.3.2...1.3.3



Commits

2cfe9f1 Merge pull request #674 from uuid-rs/cargo/1.3.3
2bbbb74 prepare for 1.3.3 release
534691e Merge pull request #673 from uuid-rs/chore/hard-deprecation
147d4b3 update build agents
d89c69d hard deprecate Timestamp::to_unix_nanos
6d22d0c Merge pull request #671 from uuid-rs/ci/cleanups
0536908 use sha hash for checkout action and remove others
See full diff in compare view




Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
akrantz01 referenced this pull request in akrantz01/lers May 15, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [uuid](https://togithub.com/uuid-rs/uuid) | dependencies | patch |
`1.3.2` -> `1.3.3` |

---

### Release Notes

<details>
<summary>uuid-rs/uuid</summary>

### [`v1.3.3`](https://togithub.com/uuid-rs/uuid/releases/tag/1.3.3)

[Compare
Source](https://togithub.com/uuid-rs/uuid/compare/1.3.2...1.3.3)

##### What's Changed

- Use sha hash for checkout action and remove others by
[@&#8203;KodrAus](https://togithub.com/KodrAus) in
[https://github.com/uuid-rs/uuid/pull/671](https://togithub.com/uuid-rs/uuid/pull/671)
- Hard deprecate Timestamp::to_unix_nanos by
[@&#8203;KodrAus](https://togithub.com/KodrAus) in
[https://github.com/uuid-rs/uuid/pull/673](https://togithub.com/uuid-rs/uuid/pull/673)
- Prepare for 1.3.3 release by
[@&#8203;KodrAus](https://togithub.com/KodrAus) in
[https://github.com/uuid-rs/uuid/pull/674](https://togithub.com/uuid-rs/uuid/pull/674)

**Full Changelog**:
uuid-rs/uuid@1.3.2...1.3.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/akrantz01/lers).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43OS4xIiwidXBkYXRlZEluVmVyIjoiMzUuNzkuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request May 22, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [uuid](https://github.com/uuid-rs/uuid) | dependencies | patch | `1.3.2` -> `1.3.3` |

---

### Release Notes

<details>
<summary>uuid-rs/uuid</summary>

### [`v1.3.3`](https://github.com/uuid-rs/uuid/releases/tag/1.3.3)

[Compare Source](uuid-rs/uuid@1.3.2...1.3.3)

#### What's Changed

-   Use sha hash for checkout action and remove others by [@&#8203;KodrAus](https://github.com/KodrAus) in uuid-rs/uuid#671
-   Hard deprecate Timestamp::to_unix_nanos by [@&#8203;KodrAus](https://github.com/KodrAus) in uuid-rs/uuid#673
-   Prepare for 1.3.3 release by [@&#8203;KodrAus](https://github.com/KodrAus) in uuid-rs/uuid#674

**Full Changelog**: uuid-rs/uuid@1.3.2...1.3.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS45Ni4yIiwidXBkYXRlZEluVmVyIjoiMzUuOTcuMCIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AifQ==-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1899
Reviewed-by: crapStone <crapstone@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@KodrAus KodrAus deleted the chore/hard-deprecation branch June 13, 2023 05:23
@nrxus
Copy link

nrxus commented Aug 15, 2023

@KodrAus FYI I think this PR incidentally raised the MSRV to 1.57.0. That version came out almost 2 years ago by now so it's not a big deal but it's probably worth changing the README.md as it still specifies 1.46.0 as the MSRV which is incorrect.

@KodrAus
Copy link
Member Author

KodrAus commented Aug 16, 2023

Thanks for the note @nrxus! It looks like we actually made the bump way back in #610 but never updated the readme. I'll get that sorted 🙇

@KodrAus KodrAus mentioned this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants