[Feature] Tax receipt #311
Conversation
public/assets/signature.png
Outdated
There was a problem hiding this comment.
I did not use the new file RCD sent since I think this one looks better.
public/assets/stamp.png
Outdated
There was a problem hiding this comment.
I did not use the new file RCD sent since I think this one looks better.
| paymentItems, | ||
| totalAmount, | ||
| address, | ||
| }).content.concat([ |
There was a problem hiding this comment.
This is the invoice PDF. If we have a donation, we include both the invoice and donation PDFs.
There was a problem hiding this comment.
@sherryhli I'm not sure if I fully understand what a schema change is. For instance, in this ticket, I initially wanted to have the invoice and donation be separate pdfs, however this would have required me to change the model ApplicationProcessing in the \prisma\schema.prisma file to include some donationInvoiceNumber or make each applicationinvoice be an tuple of invoices (one for donation and the other for the invoice) or something similar. I believe this is a schema change since it adds or removes something from the schema.prisma file? Because of this I instead conditionally have both the invoice and the donation receipt in one file. If the donation amount exceeds $20 the file will have both invoice and donation, otherwise it will only have the invoice.
Yeah, you're right - adding donationInvoiceNumber would be considered a schema change, we'd need to add a column to the DB. I think your approach is a good workaround!
This looks great!
Thanks for the detailed walkthrough video. Would be great if you can write up a short paragraph describing those behaviours. I think all 3 features going out in the next release would benefit from having some user documention.
* Add donation receipt pdf * Add signature and stamp pngs * Increase stamp size and add "Receipt" text to location * generate receipt * 2 separate PDFs generated * Remove unused pdf generation * Remove second step * Make combined pdf * Remove unused props * Update utils.ts * Change > $20 to >= $20 for donation generation
* [Fix] Save poaFormS3ObjectKey when updating guardian information in permit holders page (#319) * [Fix] Postal Code Space Issue (#316) * Set other gender field on permit holders page (#318) * Add .nvmrc file (#317) * [Feature] Implement applicant deletion (#310) * [Feature] Implement application deletion (#315) * Display other gender field on permit holders page (#314) * Move wallet card task in application processing (#313) * [Feature] Tax receipt (#311) * [Fix] Fix expiry date for in-progress replacement applications (#274) * [Fix] Fix APP history permit type badge (#273) * [Improvement] Adjust spacing of address in invoice (#272) * [Fix] Show validation error messages on form mount (#271)
* Add donation receipt pdf * Add signature and stamp pngs * Increase stamp size and add "Receipt" text to location * generate receipt * 2 separate PDFs generated * Remove unused pdf generation * Remove second step * Make combined pdf * Remove unused props * Update utils.ts * Change > $20 to >= $20 for donation generation
* Add donation receipt pdf * Add signature and stamp pngs * Increase stamp size and add "Receipt" text to location * generate receipt * 2 separate PDFs generated * Remove unused pdf generation * Remove second step * Make combined pdf * Remove unused props * Update utils.ts * Change > $20 to >= $20 for donation generation
* [Feature] Create setEmployeeAsActive GraphQL endpoint (#322) * [Fix] Save poaFormS3ObjectKey when updating guardian information in permit holders page (#319) * [Fix] Postal Code Space Issue (#316) * Set other gender field on permit holders page (#318) * Add .nvmrc file (#317) * [Feature] Implement applicant deletion (#310) * [Feature] Implement application deletion (#315) * Display other gender field on permit holders page (#314) * Move wallet card task in application processing (#313) * [Feature] Tax receipt (#311) * [Fix] Fix expiry date for in-progress replacement applications (#274) * [Fix] Fix APP history permit type badge (#273) * [Improvement] Adjust spacing of address in invoice (#272) * [Fix] Show validation error messages on form mount (#271)
Notion ticket link
[17] Tax Receipt PDF
Implementation description
model ApplicationProcessingin the\prisma\schema.prismafile to include some donationInvoiceNumber or make each applicationinvoice be a tuple of invoices (one for donation and the other for the invoice) or something similar. I believe this is a schema change since it adds or removes something from the schema.prisma file? Because of this I instead conditionally have both the invoice and the donation receipt in one file. If the donation amount exceeds $20 the file will have both invoice and donation, otherwise it will only have the invoice.Notes
2023-09-03.21-28-36_trimmedsmall.mp4
Checklist
[Feature],[Improvement]or[Fix],