Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Show validation error messages on form mount #271

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

OustanDing
Copy link
Member

@OustanDing OustanDing commented Sep 2, 2022

Notion ticket link

Ticket

Implementation description

  • Run validation on form mount, showing validation error messages without requiring meta.touched to be true
  • Modify physician MSP number (internal only) to support placeholder MSP number (X#####)

Notes

Checklist

  • My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
  • I have run the appropriate linter(s)
  • I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

@OustanDing OustanDing added the needs dev review Needs dev review label Sep 2, 2022
@OustanDing OustanDing self-assigned this Sep 2, 2022
@OustanDing OustanDing added ready to merge ✅ Ready to merge (all reviews received) and removed needs dev review Needs dev review labels Sep 2, 2022
@OustanDing OustanDing merged commit de66dc6 into staging Sep 2, 2022
@OustanDing OustanDing deleted the od/fix/show-error-messages-on-modal-open branch September 2, 2022 03:57
@leogjhuang leogjhuang mentioned this pull request Oct 4, 2023
3 tasks
leogjhuang added a commit that referenced this pull request Oct 4, 2023
* [Fix] Save poaFormS3ObjectKey when updating guardian information in permit holders page (#319)
* [Fix] Postal Code Space Issue (#316)
* Set other gender field on permit holders page (#318)
* Add .nvmrc file (#317)
* [Feature] Implement applicant deletion (#310)
* [Feature] Implement application deletion (#315)
* Display other gender field on permit holders page (#314)
* Move wallet card task in application processing (#313)
* [Feature] Tax receipt (#311)
* [Fix] Fix expiry date for in-progress replacement applications (#274)
* [Fix] Fix APP history permit type badge (#273)
* [Improvement] Adjust spacing of address in invoice (#272)
* [Fix] Show validation error messages on form mount (#271)
@leogjhuang leogjhuang mentioned this pull request Oct 10, 2023
3 tasks
@leogjhuang leogjhuang mentioned this pull request Oct 10, 2023
3 tasks
leogjhuang added a commit that referenced this pull request Oct 10, 2023
* [Feature] Create setEmployeeAsActive GraphQL endpoint (#322)
* [Fix] Save poaFormS3ObjectKey when updating guardian information in permit holders page (#319)
* [Fix] Postal Code Space Issue (#316)
* Set other gender field on permit holders page (#318)
* Add .nvmrc file (#317)
* [Feature] Implement applicant deletion (#310)
* [Feature] Implement application deletion (#315)
* Display other gender field on permit holders page (#314)
* Move wallet card task in application processing (#313)
* [Feature] Tax receipt (#311)
* [Fix] Fix expiry date for in-progress replacement applications (#274)
* [Fix] Fix APP history permit type badge (#273)
* [Improvement] Adjust spacing of address in invoice (#272)
* [Fix] Show validation error messages on form mount (#271)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge ✅ Ready to merge (all reviews received)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant