Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Save poaFormS3ObjectKey when updating guardian information in permit holders page #319

Merged
merged 1 commit into from
Oct 3, 2023
Merged

[Fix] Save poaFormS3ObjectKey when updating guardian information in permit holders page #319

merged 1 commit into from
Oct 3, 2023

Conversation

sherryhli
Copy link
Member

Notion ticket link

[17] Guardian/POA file upload does not save the file

Implementation description

  • Update updateApplicantGuardianInformation resolver to save the poaFormS3ObjectKey to the database

upload-poa-file

Notes

  • POA file can also be added/updated when creating or updating a new application, verified that file upload is working correctly in these cases - the problem was isolated to the permit holders page
  • There are some existing issues with file upload, namely that there is no validation logic enforcing unique S3 keys for guardians, this means a file can be overwritten if a file of the same name is uploaded for a different guardian. Chose to go with the quick fix first to resolve the originally reported issue, the overwriting issue is a bit less urgent given it hasn't been reported yet

Checklist

  • My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
  • I have run the appropriate linter(s)
  • I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

ChinemeremChigbo
ChinemeremChigbo approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@ChinemeremChigbo ChinemeremChigbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sherryhli sherryhli merged commit c189e38 into staging Oct 3, 2023
1 check passed
@sherryhli sherryhli deleted the sl/fix-guardian-file-upload branch October 3, 2023 15:22
leogjhuang pushed a commit that referenced this pull request Oct 4, 2023
@sherryhli @leogjhuang
[Fix] Save poaFormS3ObjectKey when updating guardian information in p…
f8e0705 
…ermit holders page (#319)
@leogjhuang leogjhuang mentioned this pull request Oct 4, 2023
Merged
3 tasks
leogjhuang added a commit that referenced this pull request Oct 4, 2023
@leogjhuang
[Release] Version 0.0.9 (#321)
6fb599c 
* [Fix] Save poaFormS3ObjectKey when updating guardian information in permit holders page (#319)
* [Fix] Postal Code Space Issue (#316)
* Set other gender field on permit holders page (#318)
* Add .nvmrc file (#317)
* [Feature] Implement applicant deletion (#310)
* [Feature] Implement application deletion (#315)
* Display other gender field on permit holders page (#314)
* Move wallet card task in application processing (#313)
* [Feature] Tax receipt (#311)
* [Fix] Fix expiry date for in-progress replacement applications (#274)
* [Fix] Fix APP history permit type badge (#273)
* [Improvement] Adjust spacing of address in invoice (#272)
* [Fix] Show validation error messages on form mount (#271)
leogjhuang pushed a commit that referenced this pull request Oct 10, 2023
@sherryhli @leogjhuang
[Fix] Save poaFormS3ObjectKey when updating guardian information in p…
18fc53e 
…ermit holders page (#319)
@leogjhuang leogjhuang mentioned this pull request Oct 10, 2023
Closed
3 tasks
leogjhuang pushed a commit that referenced this pull request Oct 10, 2023
@sherryhli @leogjhuang
[Fix] Save poaFormS3ObjectKey when updating guardian information in p…
a2deec8 
…ermit holders page (#319)
@leogjhuang leogjhuang mentioned this pull request Oct 10, 2023
Merged
3 tasks
leogjhuang added a commit that referenced this pull request Oct 10, 2023
@leogjhuang
[Release] Version 0.0.9 (#324)
3468852 
* [Feature] Create setEmployeeAsActive GraphQL endpoint (#322)
* [Fix] Save poaFormS3ObjectKey when updating guardian information in permit holders page (#319)
* [Fix] Postal Code Space Issue (#316)
* Set other gender field on permit holders page (#318)
* Add .nvmrc file (#317)
* [Feature] Implement applicant deletion (#310)
* [Feature] Implement application deletion (#315)
* Display other gender field on permit holders page (#314)
* Move wallet card task in application processing (#313)
* [Feature] Tax receipt (#311)
* [Fix] Fix expiry date for in-progress replacement applications (#274)
* [Fix] Fix APP history permit type badge (#273)
* [Improvement] Adjust spacing of address in invoice (#272)
* [Fix] Show validation error messages on form mount (#271)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChinemeremChigbo ChinemeremChigbo ChinemeremChigbo approved these changes

@leogjhuang leogjhuang Awaiting requested review from leogjhuang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sherryhli @ChinemeremChigbo