Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Create setEmployeeAsActive GraphQL endpoint #322

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

sherryhli
Copy link
Member

@sherryhli sherryhli commented Oct 9, 2023

Notion ticket link

[18][PROD] Issue adding new admin

Implementation description

  • Create new GraphQL endpoint to set an employee to active state
  • Meant only for internal use right now, will not expose on UI
rcd=# select * from employees where id = 16;
 id | first_name | last_name |               email                |       email_verified       | role  | active |         created_at         |          updated_at
----+------------+-----------+------------------------------------+----------------------------+-------+--------+----------------------------+-------------------------------
 16 | Sherry     | Li        | sherryli+employee2@uwblueprint.org | 2023-10-02 07:14:32.818+00 | ADMIN | f      | 2023-10-02 07:07:51.834+00 | 2023-10-03 02:10:56.007522+00 
(1 row)

image

rcd=# select * from employees where id = 16;
 id | first_name | last_name |               email                |       email_verified       | role  | active |         created_at         |          updated_at
----+------------+-----------+------------------------------------+----------------------------+-------+--------+----------------------------+-------------------------------
 16 | Sherry     | Li        | sherryli+employee2@uwblueprint.org | 2023-10-02 07:14:32.818+00 | ADMIN | t      | 2023-10-02 07:07:51.834+00 | 2023-10-09 06:50:56.119863+00 
(1 row)

Notes

  • N/A

Checklist

  • My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
  • I have run the appropriate linter(s)
  • I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

Comment on lines -77 to -86
export type DeleteApplicationInput = {
id: Scalars['Int'];
};

export type DeleteApplicationResult = {
__typename?: 'DeleteApplicationResult';
ok: Scalars['Boolean'];
error: Maybe<Scalars['String']>;
};

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-ordered in the file due to running yarn generate-graphql-types

@leogjhuang leogjhuang merged commit 5b40ca9 into staging Oct 10, 2023
1 check passed
@leogjhuang leogjhuang deleted the sl/set-employee-active-endpoint branch October 10, 2023 08:07
leogjhuang pushed a commit that referenced this pull request Oct 10, 2023
* [Feature] Create setEmployeeAsActive GraphQL endpoint

* Query employee by email instead of id
@leogjhuang leogjhuang mentioned this pull request Oct 10, 2023
3 tasks
leogjhuang pushed a commit that referenced this pull request Oct 10, 2023
* [Feature] Create setEmployeeAsActive GraphQL endpoint

* Query employee by email instead of id
@leogjhuang leogjhuang mentioned this pull request Oct 10, 2023
3 tasks
leogjhuang added a commit that referenced this pull request Oct 10, 2023
* [Feature] Create setEmployeeAsActive GraphQL endpoint (#322)
* [Fix] Save poaFormS3ObjectKey when updating guardian information in permit holders page (#319)
* [Fix] Postal Code Space Issue (#316)
* Set other gender field on permit holders page (#318)
* Add .nvmrc file (#317)
* [Feature] Implement applicant deletion (#310)
* [Feature] Implement application deletion (#315)
* Display other gender field on permit holders page (#314)
* Move wallet card task in application processing (#313)
* [Feature] Tax receipt (#311)
* [Fix] Fix expiry date for in-progress replacement applications (#274)
* [Fix] Fix APP history permit type badge (#273)
* [Improvement] Adjust spacing of address in invoice (#272)
* [Fix] Show validation error messages on form mount (#271)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants