Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Postal Code Space Issue #316

Merged
merged 2 commits into from
Oct 3, 2023
Merged

[Fix] Postal Code Space Issue #316

merged 2 commits into from
Oct 3, 2023

Conversation

ChinemeremChigbo
Copy link
Member

@ChinemeremChigbo ChinemeremChigbo commented Sep 27, 2023

Notion ticket link

[12] Cannot save edited doctor’s info for permit holder if postal code has spacing

Implementation description

  • No longer make the change for Physician postal code stripping in the frontend.
  • Physician postal codes can have a single space in them like is intended.

Notes

Checklist

  • My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
  • I have run the appropriate linter(s)
  • I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

@ChinemeremChigbo ChinemeremChigbo marked this pull request as draft September 27, 2023 17:16
@ChinemeremChigbo ChinemeremChigbo self-assigned this Oct 3, 2023
@ChinemeremChigbo ChinemeremChigbo marked this pull request as ready for review October 3, 2023 07:02
@ChinemeremChigbo ChinemeremChigbo changed the title [Draft] Fix Postal Code Space Issue [Fix] Postal Code Space Issue Oct 3, 2023
Copy link
Member

@sherryhli sherryhli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChinemeremChigbo ChinemeremChigbo merged commit e61507d into staging Oct 3, 2023
1 check passed
@ChinemeremChigbo ChinemeremChigbo deleted the postal_code branch October 3, 2023 07:42
leogjhuang pushed a commit that referenced this pull request Oct 4, 2023
* Strip first solution

* Have parity between physician and applicant upsert
@leogjhuang leogjhuang mentioned this pull request Oct 4, 2023
3 tasks
leogjhuang added a commit that referenced this pull request Oct 4, 2023
* [Fix] Save poaFormS3ObjectKey when updating guardian information in permit holders page (#319)
* [Fix] Postal Code Space Issue (#316)
* Set other gender field on permit holders page (#318)
* Add .nvmrc file (#317)
* [Feature] Implement applicant deletion (#310)
* [Feature] Implement application deletion (#315)
* Display other gender field on permit holders page (#314)
* Move wallet card task in application processing (#313)
* [Feature] Tax receipt (#311)
* [Fix] Fix expiry date for in-progress replacement applications (#274)
* [Fix] Fix APP history permit type badge (#273)
* [Improvement] Adjust spacing of address in invoice (#272)
* [Fix] Show validation error messages on form mount (#271)
leogjhuang pushed a commit that referenced this pull request Oct 10, 2023
* Strip first solution

* Have parity between physician and applicant upsert
@leogjhuang leogjhuang mentioned this pull request Oct 10, 2023
3 tasks
leogjhuang pushed a commit that referenced this pull request Oct 10, 2023
* Strip first solution

* Have parity between physician and applicant upsert
@leogjhuang leogjhuang mentioned this pull request Oct 10, 2023
3 tasks
leogjhuang added a commit that referenced this pull request Oct 10, 2023
* [Feature] Create setEmployeeAsActive GraphQL endpoint (#322)
* [Fix] Save poaFormS3ObjectKey when updating guardian information in permit holders page (#319)
* [Fix] Postal Code Space Issue (#316)
* Set other gender field on permit holders page (#318)
* Add .nvmrc file (#317)
* [Feature] Implement applicant deletion (#310)
* [Feature] Implement application deletion (#315)
* Display other gender field on permit holders page (#314)
* Move wallet card task in application processing (#313)
* [Feature] Tax receipt (#311)
* [Fix] Fix expiry date for in-progress replacement applications (#274)
* [Fix] Fix APP history permit type badge (#273)
* [Improvement] Adjust spacing of address in invoice (#272)
* [Fix] Show validation error messages on form mount (#271)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants