[Fix] Set other gender field on permit holders page #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherryhli
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Approved, feel free to merge so we can get a fix out ASAP. However, I think the schema in this case refers to the validation schema rather than the DB schema so we should be able to implement the long-term fix now.
Problem is somewhere here:
richmond-centre-for-disability/lib/applicants/validation.ts
Lines 26 to 30 in 97b8590
leogjhuang
added a commit
that referenced
this pull request
Oct 4, 2023
leogjhuang
added a commit
that referenced
this pull request
Oct 4, 2023
* [Fix] Save poaFormS3ObjectKey when updating guardian information in permit holders page (#319) * [Fix] Postal Code Space Issue (#316) * Set other gender field on permit holders page (#318) * Add .nvmrc file (#317) * [Feature] Implement applicant deletion (#310) * [Feature] Implement application deletion (#315) * Display other gender field on permit holders page (#314) * Move wallet card task in application processing (#313) * [Feature] Tax receipt (#311) * [Fix] Fix expiry date for in-progress replacement applications (#274) * [Fix] Fix APP history permit type badge (#273) * [Improvement] Adjust spacing of address in invoice (#272) * [Fix] Show validation error messages on form mount (#271)
leogjhuang
added a commit
that referenced
this pull request
Oct 10, 2023
leogjhuang
added a commit
that referenced
this pull request
Oct 10, 2023
leogjhuang
added a commit
that referenced
this pull request
Oct 10, 2023
* [Feature] Create setEmployeeAsActive GraphQL endpoint (#322) * [Fix] Save poaFormS3ObjectKey when updating guardian information in permit holders page (#319) * [Fix] Postal Code Space Issue (#316) * Set other gender field on permit holders page (#318) * Add .nvmrc file (#317) * [Feature] Implement applicant deletion (#310) * [Feature] Implement application deletion (#315) * Display other gender field on permit holders page (#314) * Move wallet card task in application processing (#313) * [Feature] Tax receipt (#311) * [Fix] Fix expiry date for in-progress replacement applications (#274) * [Fix] Fix APP history permit type badge (#273) * [Improvement] Adjust spacing of address in invoice (#272) * [Fix] Show validation error messages on form mount (#271)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notion ticket link
Cannot save edits to personal info section (name or gender) when processing new requests
Implementation description
otherGenderis set to null when updating permit holder information for new applicantsotherGenderto an empty string on saveError
Notes
otherGenderto be null, this quick fix can be removed.Checklist
[Feature],[Improvement]or[Fix],