-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added cmake support #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, this is nice.
I quickly tested it and seems to work with CMake (3.16.3), gcc (9.3.0) and nvcc (11.2.67).
It would be nice if you could add quick building/installing instructions to the README, and how it can be used/included this way in other projects.
Have you run a runtime comparison to check if the compiler flags differ and/or have impact with respect to the makefile-built version?
Thanks for reviewing. Traveling right now with a laptop that has no nvidia card. Will do the testing and make the changes you requested when returning in about 2 weeks. |
awesome, thank you. If your ROS2 project is open source, feel free to mention it in the README and link to it, if you like. |
So far I had only used the cmake package in my ROS2 package and it worked fine there. When creating a stand-alone package I discovered some transitive dependencies were not propagated correctly. Here is a performance comparison between original and cmake library tests |
def1991
to
7316d9c
Compare
I tested once more on Ubuntu 18.04 (it compiles, but not run tested) and 20.04 (compiles and run tested). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thanks a lot for your contribution!
added support for building under cmake