fix: prevent server value change for edited locked cells (#7956) (CP: 23.6) (#7966)

* fix: prevent server value change for edited locked cells (#7956)

* fix: update locked state of cached cells and prevent server value change

* fix: adapt 1 based indexes for cell address

* refactor: revert client side fixes

* chore: revert removed line

* fix tests

---------

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>

* chore: run formatter

* chore: update deprecation version

---------

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>

Author: ugur-vaadin

vaadin-spreadsheet-flow-parent/vaadin-spreadsheet-flow/src/main/java/com/vaadin/flow/component/spreadsheet/Spreadsheet.java

@@ -3760,7 +3760,7 @@ public boolean isCellHidden(Cell cell) {
      *             determine the locked state of cells that have not been
      *             created yet. Use {@link #isCellLocked(CellAddress)} instead.
      */
-    @Deprecated(since = "24.9.0", forRemoval = true)
+    @Deprecated(since = "23.6", forRemoval = true)
     public boolean isCellLocked(Cell cell) {
         if (isActiveSheetProtected()) {
             if (cell != null) {

vaadin-spreadsheet-flow-parent/vaadin-spreadsheet-flow/src/main/java/com/vaadin/flow/component/spreadsheet/SpreadsheetHandlerImpl.java

@@ -131,6 +131,10 @@ public void selectionDecreasePainted(int r, int c) {
 
     @Override
     public void cellValueEdited(int row, int col, String value) {
+        if (spreadsheet.isCellLocked(new CellAddress(row - 1, col - 1))) {
+            protectedCellWriteAttempted();
+            return;
+        }
         spreadsheet.getCellValueManager().onCellValueChange(col, row, value);
     }
 

vaadin-spreadsheet-flow-parent/vaadin-spreadsheet-flow/src/test/java/com/vaadin/flow/component/spreadsheet/tests/LockedCellValueTest.java

@@ -0,0 +1,87 @@
+/**
+ * Copyright 2000-2025 Vaadin Ltd.
+ *
+ * This program is available under Vaadin Commercial License and Service Terms.
+ *
+ * See  {@literal <https://vaadin.com/commercial-license-and-service-terms>}  for the full
+ * license.
+ */
+package com.vaadin.flow.component.spreadsheet.tests;
+
+import java.util.Locale;
+import java.util.concurrent.atomic.AtomicReference;
+
+import org.junit.After;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+
+import com.vaadin.flow.component.UI;
+import com.vaadin.flow.component.spreadsheet.Spreadsheet;
+import com.vaadin.flow.component.spreadsheet.Spreadsheet.ProtectedEditEvent;
+
+public class LockedCellValueTest {
+
+    private Spreadsheet spreadsheet;
+
+    @Before
+    public void init() {
+        spreadsheet = new Spreadsheet();
+        spreadsheet.setLocale(Locale.US);
+        var ui = new UI();
+        UI.setCurrent(ui);
+    }
+
+    @After
+    public void tearDown() {
+        UI.setCurrent(null);
+    }
+
+    @Test
+    public void lockSheet_receiveCellValueEditedEvent_preventsEdit() {
+        var cell = spreadsheet.createCell(1, 1, "Initial value");
+        lockSheet();
+        var protectedEditEvent = new AtomicReference<ProtectedEditEvent>();
+        spreadsheet.addProtectedEditListener(protectedEditEvent::set);
+        var cellValueChangeEvent = new AtomicReference<Spreadsheet.CellValueChangeEvent>();
+        spreadsheet.addCellValueChangeListener(cellValueChangeEvent::set);
+        spreadsheet.setSelection("B2");
+        fireCellValueEditedEvent(2, 2, "Updated value");
+        Assert.assertNotNull(protectedEditEvent.get());
+        Assert.assertNull(cellValueChangeEvent.get());
+        Assert.assertEquals("Initial value", cell.getStringCellValue());
+    }
+
+    @Test
+    public void lockSheet_unlockCell_receiveCellValueEditedEvent_allowsEdit() {
+        var cell = spreadsheet.createCell(1, 1, "Initial value");
+        lockSheet();
+        unlockCell("B2");
+        var protectedEditEvent = new AtomicReference<ProtectedEditEvent>();
+        spreadsheet.addProtectedEditListener(protectedEditEvent::set);
+        var cellValueChangeEvent = new AtomicReference<Spreadsheet.CellValueChangeEvent>();
+        spreadsheet.addCellValueChangeListener(cellValueChangeEvent::set);
+        spreadsheet.setSelection("B2");
+        fireCellValueEditedEvent(2, 2, "Updated value");
+        Assert.assertNull(protectedEditEvent.get());
+        Assert.assertNotNull(cellValueChangeEvent.get());
+        Assert.assertEquals("Updated value", cell.getStringCellValue());
+    }
+
+    private void fireCellValueEditedEvent(int row, int col, String value) {
+        TestHelper.fireClientEvent(spreadsheet, "cellValueEdited",
+                "[" + row + ", " + col + ", \"" + value + "\"]");
+    }
+
+    private void lockSheet() {
+        spreadsheet.setSheetProtected(0, "password");
+    }
+
+    private void unlockCell(String cellAddress) {
+        spreadsheet.createCell(0, 0, "");
+        var cellStyle = spreadsheet.getActiveSheet().getWorkbook()
+                .createCellStyle();
+        cellStyle.setLocked(false);
+        spreadsheet.getCell(cellAddress).setCellStyle(cellStyle);
+    }
+}