Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded web components: implement the ability to push property updates to client #5259

Closed
ujoni opened this issue Mar 13, 2019 · 3 comments
Closed
Assignees
Labels
embedding flow Issues for embedding Flow applications enhancement
Milestone

Comments

@ujoni
Copy link
Contributor

ujoni commented Mar 13, 2019

Currently, properties are only synchronized to one direction: from client to server. Implement synchronization from server to client.

Currently, InstanceConfigurator receives a reference to a WebComponent, which is proposed to look like this:

public interface WebComponent<C extends Component> extends Serializable {
    <P extends Serializable> void setProperty(
            PropertyConfiguration<C, P> propertyConfiguration, P value);

    <P extends Serializable> P getProperty(PropertyConfiguration<C, P> propertyConfiguration);
}

Either provide implementation to WebComponent or find another way.

@pleku pleku changed the title Embedded web components: implement the ability to push property updates and events to client Embedded web components: implement the ability to push property updates to client Mar 14, 2019
@pleku
Copy link
Contributor

pleku commented Mar 14, 2019

Acceptance Criteria

The value to deliver is to be able to send property updates to the client. This might be anything that the embedding application is interested in, like alarming the user about a new message pushed by the server.
Add a tutorial that shows how to update the property value. The example can be for instance about number of unread messages (or something better).

@ujoni
Copy link
Contributor Author

ujoni commented Mar 25, 2019

Should we split up the embedding tutorial somewhat? It is starting to get quite large?

We could have the current tutorial (with @denis-anisimov's fireEvent additions) as a separate, large tutorial, but lift separate issues as their own topics, something like:

  • Exporting Component as a web component
    • define properties
    • write properties
  • Firing custom events
  • Enabling push for embedded components
  • Full embedded example

Or is that too much separation?

@pleku
Copy link
Contributor

pleku commented Mar 25, 2019

Should we split up the embedding tutorial somewhat? It is starting to get quite large?

Less is more. I'm fine with splitting it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embedding flow Issues for embedding Flow applications enhancement
Projects
None yet
Development

No branches or pull requests

2 participants