Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Upgrade @vaadin/vaadin-themable-mixin from 23.3.0-alpha2 to 23.3.5 #15897

Closed
wants to merge 1 commit into from

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Feb 10, 2023

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to upgrade @vaadin/vaadin-themable-mixin from 23.3.0-alpha2 to 23.3.5.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 15 versions ahead of your current version.
  • The recommended version was released 21 days ago, on 2023-01-20.
Release notes
Package name: @vaadin/vaadin-themable-mixin
  • 23.3.5 - 2023-01-20

    API Documentation →

    Changes Since v23.3.4

    🐛 Bug Fixes

    • combo-box
    • multi-select-combo-box
      • Do not throw when multi-select-combo-box is templatized (#5336) (#5337)
  • 23.3.4 - 2023-01-16

    API Documentation →

    Changes Since v23.3.3

    💥 Behavior Altering Fixes

    • checkbox, radio-group
      • Improve checkbox and radio-button baseline alignment (#5288) (#5292)

    🐛 Bug Fixes

    • dialog
      • Do not throw on requestContentUpdate before attach (#5285) (#5286)
    • grid
      • Allow programmatically multi-sorting if multiSortOnShiftClick is enabled (#5296) (#5311)
      • Ignore label element clicks in grid cells (#5271) (#5273)
      • Do not consider label and hidden elements focusable (#5263) (#5265)

    💅 Polish

    • checkbox,radio-group,vaadin-lumo-styles,vaadin-material-styles
      • Make globals opt-in for backwards compatibility (#5302) (#5313)
      • Move component properties defaults to themes (#5295) (#5297)
  • 23.3.3 - 2023-01-09

    API Documentation →

    Changes Since v23.3.2

    💥 Behavior Altering Fixes

    • integer-field,number-field
      • Revalidate number fields after bad input is removed (#5138) (#5208)

    🐛 Bug Fixes

    • combo-box,time-picker
      • Set aria-setsize attribute on items instead of the scroller (#5254) (#5255)
    • component-base
      • Handle large item height differences in virtualizer (#5135) (#5201)
    • context-menu
      • Do not throw on requestContentUpdate before attach (#5223) (#5224)
    • field-base,login
      • Propagate autocapitalize attribute in Chrome (#5175) (#5176)

    📝 Documentation

    • combo-box
      • Use fetch in combo-box dataProvider example (#5217) (#5218)
    • field-base
      • Remove incorrect usage of DisabledMixin types (#5179) (#5183)
    • message-input
      • Add missing JSDoc annotation for the submit event (#5259) (#5260)
    • vaadin-lumo-styles,vaadin-material-styles
      • Add private JSDoc annotation to theme classes (#5203) (#5204)

    🔬 Tests

    • avatar-group
      • Add missing avatar-group overlay snapshot tests (#5244) (#5248)
      • Add missing typings tests to vaadin-avatar-group (#5243) (#5246)
    • context-menu
      • Improve context-menu Lit renderer tests formatting (#5226) (#5228)
    • menu-bar
      • Add missing snapshot tests to vaadin-menu-bar (#5235) (#5236)
    • time-picker
      • Update and fix vaadin-time-picker snapshot tests (#5239) (#5241)
  • 23.3.2 - 2022-12-23
  • 23.3.1 - 2022-12-19
  • 23.3.0 - 2022-12-12
  • 23.3.0-rc1 - 2022-12-07
  • 23.3.0-beta2 - 2022-11-30
  • 23.3.0-beta1 - 2022-11-22
  • 23.3.0-alpha8 - 2022-11-21
  • 23.3.0-alpha7 - 2022-11-18
  • 23.3.0-alpha6 - 2022-11-13
  • 23.3.0-alpha5 - 2022-11-04
  • 23.3.0-alpha4 - 2022-10-28
  • 23.3.0-alpha3 - 2022-10-10
  • 23.3.0-alpha2 - 2022-09-26
from @vaadin/vaadin-themable-mixin GitHub release notes
Commit messages
Package name: @vaadin/vaadin-themable-mixin

Compare


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

🧐 View latest project report

🛠 Adjust upgrade PR settings

🔕 Ignore this dependency or unsubscribe from future upgrade PRs

@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@@ -12,7 +12,7 @@
"@vaadin/router": "1.7.4",
"@vaadin/vaadin-lumo-styles": "23.3.0-alpha2",
"@vaadin/vaadin-text-field": "23.3.0-alpha2",
"@vaadin/vaadin-themable-mixin": "23.3.0-alpha2",
"@vaadin/vaadin-themable-mixin": "23.3.5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it only changes one component here, shouldn't change all?
But, probably this file should be updated at once, once there is a new version, or perhaps remove it and autogenerate by flow each time

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version is actually taken from flow-tests/test-resources/src/main/java/com/vaadin/flow/uitest/ui/dependencies/TestVersion.java as it is used as a NpmPackage version, but Snyk only tries to update the pacakge.json.
The tests should be executed and then committed to get the correct versions.
I'll close these as they use the wrong version in the wrong way.

@github-actions
Copy link

Test Results

   946 files  ±0     946 suites  ±0   56m 23s ⏱️ - 1m 38s
5 918 tests ±0  5 883 ✔️ ±0  35 💤 ±0  0 ±0 
6 176 runs  ±0  6 134 ✔️ ±0  42 💤 ±0  0 ±0 

Results for commit cbf5e76. ± Comparison against base commit 402b2b6.

@caalador
Copy link
Contributor

Closing as wrong major and updated in the wrong place.

@caalador caalador closed this Feb 13, 2023
@caalador caalador deleted the snyk-upgrade-6f24cf714cb292277394ed26c5a26433 branch February 13, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants