Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Check for null when handling exception #17542

Merged
merged 1 commit into from
Sep 4, 2023
Merged

fix: Check for null when handling exception #17542

merged 1 commit into from
Sep 4, 2023

Conversation

caalador
Copy link
Contributor

@caalador caalador commented Sep 4, 2023

For errors in beforeClientResponse
handle cases where any part to the
errorHandler is null

Fixes #17352

@caalador
fix: Check for null when handling exception
35958cf 
For errors in beforeClientResponse
handle cases where any part to the
errorHandler is null

Fixes #17352
@caalador caalador requested a review from mshabarov September 4, 2023 07:33
@caalador caalador mentioned this pull request Sep 4, 2023
Merged
@mshabarov mshabarov enabled auto-merge (squash) September 4, 2023 07:34
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Test Results

1 005 files  ±0  1 005 suites  ±0   1h 7m 11s ⏱️ + 1m 15s
6 397 tests +2  6 356 ✔️ +2  41 💤 ±0  0 ❌ ±0 
6 654 runs  +3  6 606 ✔️ +3  48 💤 ±0  0 ❌ ±0 

Results for commit 35958cf. ± Comparison against base commit fb73689.

@mshabarov mshabarov merged commit 2025d97 into main Sep 4, 2023
@mshabarov mshabarov deleted the issues/17352-null-errorhandler branch September 4, 2023 07:52
vaadin-bot pushed a commit that referenced this pull request Sep 4, 2023
@caalador @vaadin-bot
fix: Check for null when handling exception (#17542)
42ed352 
For errors in beforeClientResponse
handle cases where any part to the
errorHandler is null

Fixes #17352
vaadin-bot pushed a commit that referenced this pull request Sep 4, 2023
@caalador @vaadin-bot
fix: Check for null when handling exception (#17542)
ad2239b 
For errors in beforeClientResponse
handle cases where any part to the
errorHandler is null

Fixes #17352
vaadin-bot pushed a commit that referenced this pull request Sep 4, 2023
@caalador @vaadin-bot
fix: Check for null when handling exception (#17542)
b2f9744 
For errors in beforeClientResponse
handle cases where any part to the
errorHandler is null

Fixes #17352
vaadin-bot added a commit that referenced this pull request Sep 4, 2023
@vaadin-bot @caalador
fix: Check for null when handling exception (#17542) (#17545)
86c754c 
For errors in beforeClientResponse
handle cases where any part to the
errorHandler is null

Fixes #17352

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
vaadin-bot added a commit that referenced this pull request Sep 4, 2023
@vaadin-bot @caalador
fix: Check for null when handling exception (#17542) (#17544)
e70381d 
For errors in beforeClientResponse
handle cases where any part to the
errorHandler is null

Fixes #17352

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
vaadin-bot added a commit that referenced this pull request Sep 4, 2023
@vaadin-bot @caalador
fix: Check for null when handling exception (#17542) (#17543)
a5325b3 
For errors in beforeClientResponse
handle cases where any part to the
errorHandler is null

Fixes #17352

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.2.0.alpha10 and is also targeting the upcoming stable 24.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshabarov mshabarov mshabarov approved these changes

Assignees
No one assigned
Labels
cherry-picked-23.3 cherry-picked-24.0 cherry-picked-24.1 prerelease version for Vaadin 24.2.0 Released with Vaadin 24.2.0.alpha10 target/23.3 target/24.1 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom ErrorHandler implementation's UI changes are ignored
3 participants
@caalador @vaadin-bot @mshabarov