Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid null check (#5132) #5138

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Fix invalid null check (#5132) #5138

merged 1 commit into from
Feb 28, 2019

Conversation

caalador
Copy link
Contributor

@caalador caalador commented Feb 27, 2019 •
edited by SomeoneToIgnore
Loading

Cherry pick from master

This change is Reviewable

ZheSun88
ZheSun88 approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@ZheSun88 ZheSun88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all discussions resolved, 1 of 1 LGTMs obtained

@ZheSun88
Copy link
Contributor

flow 2.0-snapshot failed also https://bender.vaadin.com/viewType.html?buildTypeId=Flow_Snapshots_Flow20Snapshots, and this branch is failing on the same error

@caalador caalador merged commit ee19d92 into 2.0 Feb 28, 2019
@caalador caalador deleted the issues/check_fix branch February 28, 2019 05:42
@caalador
Copy link
Contributor Author

That's a bit of a flaky test. I'm trying to make it better in another branch.

@caalador caalador added this to the 2.0.0.alpha1 milestone Mar 15, 2019
This was referenced Jan 30, 2023
Closed
Closed
Closed
Closed
This was referenced Feb 6, 2023
Closed
Closed
Closed
Closed
This was referenced Feb 10, 2023
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZheSun88 ZheSun88 ZheSun88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0.alpha1
Development

Successfully merging this pull request may close these issues.
2 participants
@caalador @ZheSun88