Insert head elements to make theme work. Avoid repeated theme imports #5254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manolo
force-pushed
the
mcm/npm/fix-custom-theme
branch
3 times, most recently
from
8b42ea4
to
bef2d15
Compare
manolo
force-pushed
the
mcm/npm/fix-custom-theme
branch
from
bef2d15
to
0de1f4e
Compare
caalador
approved these changes
Mar 13, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all discussions resolved, 1 of 1 LGTMs obtained (waiting on @bogdanudrescu)
bogdanudrescu
approved these changes
Mar 13, 2019
There was a problem hiding this comment.
Reviewable status:
|
Based on the subject line, #4872 might be fixed by this PR. Can you verify that? |
This was referenced Jan 30, 2023
This was referenced Feb 6, 2023
This was referenced Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is