refactor!: remove generated Lumo CSS #358
Merged
+41
−351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 10, 2025
web-padawan
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the generated Lumo CSS files from
@vaadin/react-components. In v25 the@vaadin/vaadin-lumo-stylespackage ships CSS files which can be imported instead.One exception is the
utility.module.csswhich is kept for backwards compatibility as applications using that would have references to it all over the codebase. Thegenerate-css.tsscript has been modified to only generate to only generate the utilities CSS modules, which is done by copying over the respective CSS files from@vaadin/vaadin-lumo-styleswhile preserving the naming convention the CSS modules used previously.Related to vaadin/web-components#10057
Type of change