refactor!: remove generated Lumo CSS files #346
Conversation
| "./css/lumo/Style.css": "./css/lumo/Style.css", | ||
| "./css/lumo/Typography.css": "./css/lumo/Typography.css", | ||
| "./css/lumo/UserColors.css": "./css/lumo/UserColors.css", | ||
| "./css/lumo/Utility.module.css": "./css/lumo/Utility.module.css", |
There was a problem hiding this comment.
While loading Lumo is otherwise a one-liner, this utility module could cause a lot of changes as using it would leave references all over the codebase. Let's discuss with the team how to proceed with it.
There also needs to be a note about removing the CSS files from this package in the upgrade guide.
There was a problem hiding this comment.
Yes, makes sense. I wanted to remove it mainly so we could drop Lumo JS eventually (as these CSS files are generated from JS modules that are still present although not supposed to be used anymore).
There was a problem hiding this comment.
One option would be to just put the current version of that file in the repo. Not sure how we would mark it as deprecated though. But again, let's discuss options first.
There was a problem hiding this comment.
Created #358 as an alternative.
|
Closing in favor of #358 |
Description
As we'll change Lumo to be based on CSS files, let's remove generating of CSS from this repo.
Type of change