Skip to content

Commit 3181c97

Browse files
authored
fix: use correct type for selectedValues property (#177)
1 parent f812ab3 commit 3181c97

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

packages/vaadin-list-box/src/vaadin-list-box.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export type ListBoxSelectedChanged = CustomEvent<{ value: number }>;
1717
/**
1818
* Fired when the `selectedValues` property changes.
1919
*/
20-
export type ListBoxSelectedValuesChanged = CustomEvent<{ value: Array<string> }>;
20+
export type ListBoxSelectedValuesChanged = CustomEvent<{ value: Array<number> }>;
2121

2222
export interface ListBoxElementEventMap {
2323
'items-changed': ListBoxItemsChanged;

packages/vaadin-list-box/test/typings/list-box.types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ listBox.addEventListener('selected-changed', (event) => {
1313
});
1414

1515
listBox.addEventListener('selected-values-changed', (event) => {
16-
assert<string[]>(event.detail.value);
16+
assert<number[]>(event.detail.value);
1717
});

packages/vaadin-list-mixin/vaadin-multi-select-list-mixin.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ interface MultiSelectListMixin extends ListMixin {
2121
* Array of indexes of the items selected in the items array
2222
* Note: Not updated when used in single selection mode.
2323
*/
24-
selectedValues: string[] | null | undefined;
24+
selectedValues: number[] | null | undefined;
2525

2626
_onMultipleClick(event: MouseEvent): void;
2727
}

packages/vaadin-list-mixin/vaadin-multi-select-list-mixin.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export const MultiSelectListMixin = (superClass) =>
2828
/**
2929
* Array of indexes of the items selected in the items array
3030
* Note: Not updated when used in single selection mode.
31-
* @type {string[] | null | undefined}
31+
* @type {number[] | null | undefined}
3232
*/
3333
selectedValues: {
3434
type: Array,

0 commit comments

Comments
 (0)