Skip to content

Commit 6b0cfe4

Browse files
committed
refactor: remove workaround for old Firefox
1 parent 466d5cb commit 6b0cfe4

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

packages/vaadin-radio-button/src/vaadin-radio-group.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -335,10 +335,8 @@ class RadioGroupElement extends ThemableMixin(DirMixin(PolymerElement)) {
335335

336336
this.addEventListener('focusin', () => this._setFocused(this._containsFocus()));
337337

338-
// Need to check e.composed as a workaround for https://bugzilla.mozilla.org/show_bug.cgi?id=1472887
339-
// otherwise FF runs validation on keyboard focus
340-
this.addEventListener('focusout', (e) => {
341-
e.composed && this.validate();
338+
this.addEventListener('focusout', () => {
339+
this.validate();
342340
this._setFocused(false);
343341
});
344342
}

packages/vaadin-radio-button/test/radio-group.test.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -499,12 +499,6 @@ describe('radio-group', () => {
499499
expect(group.invalid).to.be.true;
500500
});
501501

502-
it('should not validate on focusout when event is not composed', () => {
503-
group.required = true;
504-
focusout(group, false);
505-
expect(group.invalid).to.be.false;
506-
});
507-
508502
it('should dispatch invalid-changed event when invalid changes', () => {
509503
const spy = sinon.spy();
510504
group.addEventListener('invalid-changed', spy);

0 commit comments

Comments
 (0)