Skip to content

Commit 0b461d5

Browse files
authored
test: extend dialog snapshots to cover overlay shadow DOM (#9941)
1 parent d6594af commit 0b461d5

File tree

2 files changed

+75
-13
lines changed

2 files changed

+75
-13
lines changed

packages/dialog/test/dom/__snapshots__/dialog.test.snap.js

Lines changed: 65 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/* @web/test-runner snapshot v1 */
22
export const snapshots = {};
33

4-
snapshots["vaadin-dialog host"] =
4+
snapshots["vaadin-dialog host"] =
55
`<vaadin-dialog
66
opened=""
77
role="dialog"
@@ -12,7 +12,7 @@ snapshots["vaadin-dialog host"] =
1212
`;
1313
/* end snapshot vaadin-dialog host */
1414

15-
snapshots["vaadin-dialog overlay"] =
15+
snapshots["vaadin-dialog shadow"] =
1616
`<vaadin-dialog-overlay
1717
exportparts="backdrop, overlay, header, title, header-content, content, footer"
1818
focus-trap=""
@@ -41,9 +41,9 @@ snapshots["vaadin-dialog overlay"] =
4141
</slot>
4242
</vaadin-dialog-overlay>
4343
`;
44-
/* end snapshot vaadin-dialog overlay */
44+
/* end snapshot vaadin-dialog shadow */
4545

46-
snapshots["vaadin-dialog overlay modeless"] =
46+
snapshots["vaadin-dialog modeless"] =
4747
`<vaadin-dialog-overlay
4848
exportparts="backdrop, overlay, header, title, header-content, content, footer"
4949
focus-trap=""
@@ -72,9 +72,9 @@ snapshots["vaadin-dialog overlay modeless"] =
7272
</slot>
7373
</vaadin-dialog-overlay>
7474
`;
75-
/* end snapshot vaadin-dialog overlay modeless */
75+
/* end snapshot vaadin-dialog modeless */
7676

77-
snapshots["vaadin-dialog overlay theme"] =
77+
snapshots["vaadin-dialog theme"] =
7878
`<vaadin-dialog-overlay
7979
exportparts="backdrop, overlay, header, title, header-content, content, footer"
8080
focus-trap=""
@@ -104,4 +104,62 @@ snapshots["vaadin-dialog overlay theme"] =
104104
</slot>
105105
</vaadin-dialog-overlay>
106106
`;
107-
/* end snapshot vaadin-dialog overlay theme */
107+
/* end snapshot vaadin-dialog theme */
108+
109+
snapshots["vaadin-dialog overlay"] =
110+
`<div
111+
id="backdrop"
112+
part="backdrop"
113+
>
114+
</div>
115+
<div
116+
id="overlay"
117+
part="overlay"
118+
tabindex="0"
119+
>
120+
<section
121+
class="resizer-container"
122+
id="resizerContainer"
123+
>
124+
<header part="header">
125+
<div part="title">
126+
<slot name="title">
127+
</slot>
128+
</div>
129+
<div part="header-content">
130+
<slot name="header-content">
131+
</slot>
132+
</div>
133+
</header>
134+
<div
135+
id="content"
136+
part="content"
137+
>
138+
<slot>
139+
</slot>
140+
</div>
141+
<footer part="footer">
142+
<slot name="footer">
143+
</slot>
144+
</footer>
145+
<div class="edge n resizer">
146+
</div>
147+
<div class="e edge resizer">
148+
</div>
149+
<div class="edge resizer s">
150+
</div>
151+
<div class="edge resizer w">
152+
</div>
153+
<div class="nw resizer">
154+
</div>
155+
<div class="ne resizer">
156+
</div>
157+
<div class="resizer se">
158+
</div>
159+
<div class="resizer sw">
160+
</div>
161+
</section>
162+
</div>
163+
`;
164+
/* end snapshot vaadin-dialog overlay */
165+

packages/dialog/test/dom/dialog.test.js

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,19 +26,23 @@ describe('vaadin-dialog', () => {
2626
await expect(dialog).dom.to.equalSnapshot(SNAPSHOT_CONFIG);
2727
});
2828

29-
it('overlay', async () => {
30-
await expect(overlay).dom.to.equalSnapshot(SNAPSHOT_CONFIG);
29+
it('shadow', async () => {
30+
await expect(dialog).shadowDom.to.equalSnapshot(SNAPSHOT_CONFIG);
3131
});
3232

33-
it('overlay modeless', async () => {
33+
it('modeless', async () => {
3434
dialog.modeless = true;
3535
await nextUpdate(dialog);
36-
await expect(overlay).dom.to.equalSnapshot(SNAPSHOT_CONFIG);
36+
await expect(dialog).shadowDom.to.equalSnapshot(SNAPSHOT_CONFIG);
3737
});
3838

39-
it('overlay theme', async () => {
39+
it('theme', async () => {
4040
dialog.setAttribute('theme', 'custom');
4141
await nextUpdate(dialog);
42-
await expect(overlay).dom.to.equalSnapshot(SNAPSHOT_CONFIG);
42+
await expect(dialog).shadowDom.to.equalSnapshot(SNAPSHOT_CONFIG);
43+
});
44+
45+
it('overlay', async () => {
46+
await expect(overlay).shadowDom.to.equalSnapshot(SNAPSHOT_CONFIG);
4347
});
4448
});

0 commit comments

Comments
 (0)