refactor: remove no longer used setNestedOverlay logic and tests (#9813)

Author: web-padawan

packages/overlay/src/vaadin-overlay-stack-mixin.js

@@ -53,23 +53,6 @@ export const isLastOverlay = (overlay, filter = (_overlay) => true) => {
   return overlay === filteredOverlays.pop();
 };
 
-const overlayMap = new WeakMap();
-
-/**
- * Stores the reference to the nested overlay for given parent,
- * or removes it when the nested overlay is null.
- * @param {HTMLElement} parent
- * @param {HTMLElement} nested
- * @protected
- */
-export const setNestedOverlay = (parent, nested) => {
-  if (nested != null) {
-    overlayMap.set(parent, nested);
-  } else {
-    overlayMap.delete(parent);
-  }
-};
-
 /**
  * @polymerMixin
  */
@@ -133,11 +116,6 @@ export const OverlayStackMixin = (superClass) =>
       // Update order of attached instances
       this._removeAttachedInstance();
       this._appendAttachedInstance();
-
-      // If there is a nested overlay, call `bringToFront()` for it as well.
-      if (overlayMap.has(this)) {
-        overlayMap.get(this).bringToFront();
-      }
     }
 
     /** @protected */

packages/overlay/test/multiple.test.js

@@ -2,7 +2,6 @@ import { expect } from '@vaadin/chai-plugins';
 import { click, escKeyDown, fixtureSync, nextRender } from '@vaadin/testing-helpers';
 import sinon from 'sinon';
 import '../src/vaadin-overlay.js';
-import { setNestedOverlay } from '../src/vaadin-overlay-stack-mixin.js';
 import { createOverlay } from './helpers.js';
 
 describe('multiple overlays', () => {
@@ -375,62 +374,4 @@ describe('multiple overlays', () => {
       });
     });
   });
-
-  describe('setNestedOverlay', () => {
-    let overlays;
-
-    beforeEach(() => {
-      overlays = Array.from(
-        fixtureSync(`
-        <div id="parent">
-          <vaadin-overlay modeless></vaadin-overlay>
-          <vaadin-overlay modeless></vaadin-overlay>
-          <vaadin-overlay modeless></vaadin-overlay>
-        </div>
-      `).children,
-      );
-      overlays.forEach((el, idx) => {
-        el.renderer = (root) => {
-          if (!root.firstChild) {
-            const btn = document.createElement('button');
-            btn.textContent = `Overlay ${idx}`;
-            root.appendChild(btn);
-          }
-        };
-        el.opened = true;
-      });
-    });
-
-    afterEach(() => {
-      overlays.forEach((el) => {
-        el.opened = false;
-      });
-    });
-
-    it('should bring nested overlays to front recursively', () => {
-      setNestedOverlay(overlays[0], overlays[1]);
-      setNestedOverlay(overlays[1], overlays[2]);
-
-      const bringToFrontSpy1 = sinon.spy(overlays[1], 'bringToFront');
-      const bringToFrontSpy2 = sinon.spy(overlays[2], 'bringToFront');
-
-      overlays[0].bringToFront();
-
-      expect(bringToFrontSpy1).to.be.calledOnce;
-      expect(bringToFrontSpy2).to.be.calledOnce;
-      expect(bringToFrontSpy2).to.be.calledAfter(bringToFrontSpy1);
-    });
-
-    it('should not bring nested overlay to front when resetting', () => {
-      setNestedOverlay(overlays[0], overlays[1]);
-
-      setNestedOverlay(overlays[0], null);
-
-      const bringToFrontSpy = sinon.spy(overlays[1], 'bringToFront');
-
-      overlays[0].bringToFront();
-
-      expect(bringToFrontSpy).to.be.not.called;
-    });
-  });
 });