refactor!: update vaadin-overlay to use native popover by default (#9848)

Author: web-padawan

packages/avatar-group/src/vaadin-avatar-group-overlay.js

@@ -45,22 +45,6 @@ class AvatarGroupOverlay extends PositionMixin(
       </div>
     `;
   }
-
-  /**
-   * @protected
-   * @override
-   */
-  _attachOverlay() {
-    this.showPopover();
-  }
-
-  /**
-   * @protected
-   * @override
-   */
-  _detachOverlay() {
-    this.hidePopover();
-  }
 }
 
 defineCustomElement(AvatarGroupOverlay);

packages/avatar-group/src/vaadin-avatar-group.js

@@ -83,7 +83,6 @@ class AvatarGroup extends AvatarGroupMixin(ElementMixin(ThemableMixin(PolylitMix
       </div>
       <vaadin-avatar-group-overlay
         id="overlay"
-        popover="manual"
         .owner="${this}"
         .opened="${this._opened}"
         .positionTarget="${this._overflow}"

packages/combo-box/src/vaadin-combo-box-overlay.js

@@ -45,22 +45,6 @@ export class ComboBoxOverlay extends ComboBoxOverlayMixin(
       </div>
     `;
   }
-
-  /**
-   * @protected
-   * @override
-   */
-  _attachOverlay() {
-    this.showPopover();
-  }
-
-  /**
-   * @protected
-   * @override
-   */
-  _detachOverlay() {
-    this.hidePopover();
-  }
 }
 
 defineCustomElement(ComboBoxOverlay);

packages/combo-box/src/vaadin-combo-box.js

@@ -219,7 +219,6 @@ class ComboBox extends ComboBoxDataProviderMixin(
 
       <vaadin-combo-box-overlay
         id="overlay"
-        popover="manual"
         exportparts="overlay, content, loader"
         .owner="${this}"
         .dir="${this.dir}"

packages/confirm-dialog/src/vaadin-confirm-dialog-overlay.js

@@ -83,22 +83,6 @@ class ConfirmDialogOverlay extends OverlayMixin(DirMixin(ThemableMixin(PolylitMi
     this.setAttribute('has-footer', '');
   }
 
-  /**
-   * @protected
-   * @override
-   */
-  _attachOverlay() {
-    this.showPopover();
-  }
-
-  /**
-   * @protected
-   * @override
-   */
-  _detachOverlay() {
-    this.hidePopover();
-  }
-
   /**
    * Override method from OverlayFocusMixin to use owner as content root
    * @protected

packages/confirm-dialog/src/vaadin-confirm-dialog.js

@@ -90,7 +90,6 @@ class ConfirmDialog extends ConfirmDialogMixin(ElementMixin(ThemePropertyMixin(P
     return html`
       <vaadin-confirm-dialog-overlay
         id="overlay"
-        popover="manual"
         .owner="${this}"
         .opened="${this.opened}"
         theme="${ifDefined(this._theme)}"

packages/context-menu/src/vaadin-menu-overlay-mixin.js

@@ -57,7 +57,6 @@ export const MenuOverlayMixin = (superClass) =>
     ready() {
       super.ready();
 
-      this.popover = 'manual';
       this.restoreFocusOnClose = true;
 
       this.addEventListener('keydown', (e) => {
@@ -169,20 +168,4 @@ export const MenuOverlayMixin = (superClass) =>
     _deepContains(node) {
       return this.owner.contains(node);
     }
-
-    /**
-     * @protected
-     * @override
-     */
-    _attachOverlay() {
-      this.showPopover();
-    }
-
-    /**
-     * @protected
-     * @override
-     */
-    _detachOverlay() {
-      this.hidePopover();
-    }
   };

packages/crud/src/vaadin-crud-dialog.js

@@ -82,22 +82,6 @@ class CrudDialogOverlay extends OverlayMixin(DirMixin(ThemableMixin(PolylitMixin
     this.setAttribute('has-header', '');
     this.setAttribute('has-footer', '');
   }
-
-  /**
-   * @protected
-   * @override
-   */
-  _attachOverlay() {
-    this.showPopover();
-  }
-
-  /**
-   * @protected
-   * @override
-   */
-  _detachOverlay() {
-    this.hidePopover();
-  }
 }
 
 defineCustomElement(CrudDialogOverlay);
@@ -143,7 +127,6 @@ class CrudDialog extends DialogBaseMixin(OverlayClassMixin(ThemePropertyMixin(Po
     return html`
       <vaadin-crud-dialog-overlay
         id="overlay"
-        popover="manual"
         .owner="${this.crudElement}"
         .opened="${this.opened}"
         @opened-changed="${this._onOverlayOpened}"

packages/date-picker/src/vaadin-date-picker-overlay.js

@@ -56,22 +56,6 @@ class DatePickerOverlay extends DatePickerOverlayMixin(
   get _contentRoot() {
     return this.owner._overlayContent;
   }
-
-  /**
-   * @protected
-   * @override
-   */
-  _attachOverlay() {
-    this.showPopover();
-  }
-
-  /**
-   * @protected
-   * @override
-   */
-  _detachOverlay() {
-    this.hidePopover();
-  }
 }
 
 defineCustomElement(DatePickerOverlay);

packages/date-picker/src/vaadin-date-picker.js

@@ -211,7 +211,6 @@ class DatePicker extends DatePickerMixin(
 
       <vaadin-date-picker-overlay
         id="overlay"
-        popover="manual"
         .owner="${this}"
         ?fullscreen="${this._fullscreen}"
         theme="${ifDefined(this._theme)}"