Skip to content

Commit 65d0126

Browse files
authored
test: fix overlay position tests to pass with base styles (#9554)
1 parent df3e4e1 commit 65d0126

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

packages/overlay/test/position-mixin.test.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ describe('position mixin', () => {
109109
beforeEach(() => {
110110
overlay.verticalAlign = TOP;
111111
margin = parseInt(getComputedStyle(overlay).bottom, 10);
112-
targetPositionToFlipOverlay = document.documentElement.clientHeight - overlayContent.clientHeight - margin;
112+
targetPositionToFlipOverlay = document.documentElement.clientHeight - overlayContent.offsetHeight - margin;
113113
targetPositionForCentering = document.documentElement.clientHeight / 2 - target.clientHeight / 2;
114114
});
115115

@@ -193,7 +193,7 @@ describe('position mixin', () => {
193193
beforeEach(() => {
194194
overlay.noVerticalOverlap = true;
195195
targetPositionToFlipOverlay =
196-
document.documentElement.clientHeight - overlayContent.clientHeight - margin - target.clientHeight;
196+
document.documentElement.clientHeight - overlayContent.offsetHeight - margin - target.clientHeight;
197197
});
198198

199199
it('should align below the target', () => {
@@ -232,7 +232,7 @@ describe('position mixin', () => {
232232
beforeEach(() => {
233233
overlay.verticalAlign = BOTTOM;
234234
margin = parseInt(getComputedStyle(overlay).top, 10);
235-
targetPositionToFlipOverlay = margin + overlayContent.clientHeight - target.clientHeight;
235+
targetPositionToFlipOverlay = margin + overlayContent.offsetHeight - target.clientHeight;
236236
targetPositionForCentering = document.documentElement.clientHeight / 2 - target.clientHeight / 2;
237237
});
238238

@@ -297,7 +297,7 @@ describe('position mixin', () => {
297297
describe('no overlap', () => {
298298
beforeEach(() => {
299299
overlay.noVerticalOverlap = true;
300-
targetPositionToFlipOverlay = margin + overlayContent.clientHeight;
300+
targetPositionToFlipOverlay = margin + overlayContent.offsetHeight;
301301
});
302302

303303
it('should align above the target', () => {
@@ -358,7 +358,7 @@ describe('position mixin', () => {
358358
beforeEach(() => {
359359
overlay.horizontalAlign = START;
360360
margin = parseInt(getComputedStyle(overlay).right, 10);
361-
targetPositionToFlipOverlay = document.documentElement.clientWidth - overlayContent.clientWidth - margin;
361+
targetPositionToFlipOverlay = document.documentElement.clientWidth - overlayContent.offsetWidth - margin;
362362
targetPositionForCentering = document.documentElement.clientWidth / 2 - target.clientWidth / 2;
363363
});
364364

@@ -424,7 +424,7 @@ describe('position mixin', () => {
424424
beforeEach(() => {
425425
overlay.noHorizontalOverlap = true;
426426
targetPositionToFlipOverlay =
427-
document.documentElement.clientWidth - overlayContent.clientWidth - margin - target.clientWidth;
427+
document.documentElement.clientWidth - overlayContent.offsetWidth - margin - target.clientWidth;
428428
});
429429

430430
it('should align on the right side of the target', () => {
@@ -463,7 +463,7 @@ describe('position mixin', () => {
463463
beforeEach(() => {
464464
overlay.horizontalAlign = END;
465465
margin = parseInt(getComputedStyle(overlay).left, 10);
466-
targetPositionToFlipOverlay = margin + overlayContent.clientWidth - target.clientWidth;
466+
targetPositionToFlipOverlay = margin + overlayContent.offsetWidth - target.clientWidth;
467467
targetPositionForCentering = document.documentElement.clientWidth / 2 - target.clientWidth / 2;
468468
});
469469

@@ -528,7 +528,7 @@ describe('position mixin', () => {
528528
describe('no overlap', () => {
529529
beforeEach(() => {
530530
overlay.noHorizontalOverlap = true;
531-
targetPositionToFlipOverlay = margin + overlayContent.clientWidth;
531+
targetPositionToFlipOverlay = margin + overlayContent.offsetWidth;
532532
});
533533

534534
it('should align on the left side of the target', () => {

0 commit comments

Comments
 (0)