Skip to content

Commit 67dab03

Browse files
authored
refactor: do not use phone mode backdrop in select base styles (#10083)
1 parent b612352 commit 67dab03

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

packages/select/src/styles/vaadin-select-overlay-base-styles.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,15 @@ export const selectOverlayStyles = css`
1111
justify-content: flex-start;
1212
}
1313
14-
:host(:not([phone])) [part='overlay'] {
14+
[part='overlay'] {
1515
min-width: var(--vaadin-select-overlay-width, var(--_vaadin-select-overlay-default-width));
1616
}
1717
1818
[part='content'] {
1919
padding: var(--vaadin-item-overlay-padding, 4px);
2020
}
21+
22+
[part='backdrop'] {
23+
background: transparent;
24+
}
2125
`;

packages/select/test/select.test.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -651,13 +651,6 @@ describe('vaadin-select', () => {
651651
expect(overlay.$.overlay.getBoundingClientRect().width).to.equal(400);
652652
});
653653

654-
it('should not set overlay part width based on the custom CSS property when phone', async () => {
655-
select._phone = true;
656-
select.opened = true;
657-
await oneEvent(overlay, 'vaadin-overlay-open');
658-
expect(overlay.$.overlay.getBoundingClientRect().width).to.not.equal(400);
659-
});
660-
661654
it('should store the select width in the custom CSS property on overlay opening', async () => {
662655
select.style.width = '200px';
663656
select.opened = true;

0 commit comments

Comments
 (0)