Skip to content

Commit 88c51dd

Browse files
authored
refactor: update avatar-group to use has-overflow host attribute (#9657)
1 parent 4503939 commit 88c51dd

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

packages/avatar-group/src/styles/vaadin-avatar-group-base-styles.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ export const avatarGroupStyles = css`
5656
}
5757
5858
:host(:not([theme~='reverse'])) ::slotted(vaadin-avatar:last-child),
59-
:host(:not([theme~='reverse'])) [part='container']:not(.has-overflow) ::slotted(vaadin-avatar:nth-last-child(2)),
59+
:host(:not([theme~='reverse']):not([has-overflow])) ::slotted(vaadin-avatar:nth-last-child(2)),
6060
:host([theme~='reverse']) ::slotted(vaadin-avatar:first-child) {
6161
mask-image: none;
6262
}

packages/avatar-group/src/vaadin-avatar-group-mixin.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -345,7 +345,7 @@ export const AvatarGroupMixin = (superClass) =>
345345
overflow.abbr = `+${count - this.__getLimit(count, itemsInView, maxItemsVisible)}`;
346346
const hasOverflow = maxReached || (itemsInView && itemsInView < count);
347347
overflow.toggleAttribute('hidden', !hasOverflow);
348-
this.$.container.classList.toggle('has-overflow', hasOverflow);
348+
this.toggleAttribute('has-overflow', hasOverflow);
349349
}
350350
}
351351

packages/avatar-group/test/dom/__snapshots__/avatar-group.test.snap.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,10 @@ Tomi Virkki
161161
/* end snapshot vaadin-avatar-group theme */
162162

163163
snapshots["vaadin-avatar-group opened default"] =
164-
`<vaadin-avatar-group aria-label="Currently 4 active users">
164+
`<vaadin-avatar-group
165+
aria-label="Currently 4 active users"
166+
has-overflow=""
167+
>
165168
<vaadin-avatar
166169
abbr="AD"
167170
aria-describedby="vaadin-tooltip-8"

0 commit comments

Comments
 (0)