Skip to content

Commit a0a016d

Browse files
authored
chore: disable length-zero-no-unit rule for custom properties (#9818)
1 parent 1700588 commit a0a016d

File tree

8 files changed

+8
-12
lines changed

8 files changed

+8
-12
lines changed

.stylelintrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
],
2323
"rules": {
2424
"color-function-notation": "legacy",
25+
"length-zero-no-unit": [true, { "ignore": ["custom-properties"] }],
2526
"no-duplicate-selectors": true
2627
}
2728
}

packages/dashboard/src/styles/vaadin-dashboard-section-base-styles.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@ import { css } from 'lit';
1313
import { dashboardWidgetAndSectionStyles } from './vaadin-dashboard-widget-section-core-styles.js';
1414

1515
const sectionStyles = css`
16-
/* stylelint-disable length-zero-no-unit */
17-
1816
:host {
1917
display: grid;
2018
position: relative;

packages/dashboard/theme/lumo/vaadin-dashboard-widget-styles.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import { css, registerStyles } from '@vaadin/vaadin-themable-mixin/vaadin-themab
99
/* Styles shared between widgets and sections */
1010
const dashboardWidgetAndSection = css`
1111
/* stylelint-disable rule-empty-line-before */
12-
/* stylelint-disable length-zero-no-unit */
1312
1413
:host {
1514
--_widget-background: var(--vaadin-dashboard-widget-background, var(--lumo-base-color));
@@ -304,18 +303,21 @@ const dashboardWidget = css`
304303
:host {
305304
border: 1px solid;
306305
}
306+
307307
:host([focused]) {
308308
outline: 2px solid;
309309
outline-offset: 1px;
310310
}
311+
311312
:host([selected]) {
312313
outline-width: 1px;
313-
outline-offset: 0px;
314+
outline-offset: 0;
314315
outline-color: Highlight;
315316
}
317+
316318
:host([selected][focused]) {
317319
outline-width: 3px;
318-
outline-offset: 0px;
320+
outline-offset: 0;
319321
}
320322
}
321323
`;

packages/input-container/src/styles/vaadin-input-container-core-styles.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ export const inputContainerStyles = css`
1919
--_border-radius: var(--vaadin-input-field-border-radius, 0);
2020
--_input-border-width: var(--vaadin-input-field-border-width, 0px);
2121
--_input-border-color: var(--vaadin-input-field-border-color, transparent);
22-
/* stylelint-disable-next-line length-zero-no-unit */
2322
box-shadow: inset 0 0 0 var(--_input-border-width, 0) var(--_input-border-color);
2423
}
2524

packages/menu-bar/src/styles/vaadin-menu-bar-base-styles.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ export const menuBarStyles = css`
2222
padding: calc(var(--vaadin-focus-ring-width) + 1px);
2323
position: relative;
2424
width: 100%;
25-
/* stylelint-disable length-zero-no-unit */
2625
--_gap: var(--vaadin-menu-bar-gap, 0px);
2726
--_bw: var(--vaadin-button-border-width, 1px);
2827
gap: var(--_gap);

packages/progress-bar/src/styles/vaadin-progress-bar-base-styles.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export const progressBarStyles = css`
2222
box-sizing: border-box;
2323
height: 100%;
2424
--_padding: var(--vaadin-progress-bar-padding, 0px);
25-
padding: var(--_padding); /* stylelint-disable-line length-zero-no-unit */
25+
padding: var(--_padding);
2626
background: var(--vaadin-progress-bar-background, var(--vaadin-background-container));
2727
border-radius: var(--vaadin-progress-bar-border-radius, var(--vaadin-radius-m));
2828
border: var(--vaadin-progress-bar-border-width, 1px) solid

packages/vaadin-lumo-styles/src/components/input-container.css

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,8 @@
99
align-items: center;
1010
flex: 0 1 auto;
1111
--_border-radius: var(--vaadin-input-field-border-radius, 0);
12-
/* stylelint-disable-next-line length-zero-no-unit */
1312
--_input-border-width: var(--vaadin-input-field-border-width, 0px);
14-
/* stylelint-disable-next-line length-zero-no-unit */
15-
box-shadow: inset 0 0 0 var(--_input-border-width, 0px) var(--_input-border-color);
13+
box-shadow: inset 0 0 0 var(--_input-border-width, 0) var(--_input-border-color);
1614
background: var(--_background);
1715
padding: 0 calc(0.375em + var(--_input-container-radius) / 4 - 1px);
1816
font-weight: var(--vaadin-input-field-value-font-weight, 500);

packages/vaadin-lumo-styles/src/mixins/dashboard-item.css

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
*/
66

77
@media lumo_mixins_dashboard-item {
8-
/* stylelint-disable length-zero-no-unit */
98
:host {
109
box-sizing: border-box;
1110
--_widget-background: var(--vaadin-dashboard-widget-background, var(--lumo-base-color));

0 commit comments

Comments
 (0)