Skip to content

Commit ab8b915

Browse files
authored
refactor: remove resizer-container from confirm-dialog overlay (#9938)
1 parent 1c3f0bb commit ab8b915

File tree

3 files changed

+14
-25
lines changed

3 files changed

+14
-25
lines changed

packages/confirm-dialog/src/styles/vaadin-confirm-dialog-overlay-base-styles.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,6 @@ const confirmDialogOverlay = css`
3434
[part='content'] {
3535
flex: 1;
3636
}
37-
38-
/* TODO remove this wrapper element */
39-
#resizerContainer {
40-
display: contents;
41-
}
4237
`;
4338

4439
export const confirmDialogOverlayStyles = [overlayStyles, dialogOverlayBase, confirmDialogOverlay];

packages/confirm-dialog/src/vaadin-confirm-dialog-overlay.js

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -50,23 +50,21 @@ class ConfirmDialogOverlay extends OverlayMixin(DirMixin(ThemableMixin(PolylitMi
5050
return html`
5151
<div part="backdrop" id="backdrop" ?hidden="${!this.withBackdrop}"></div>
5252
<div part="overlay" id="overlay" tabindex="0">
53-
<section id="resizerContainer" class="resizer-container">
54-
<header part="header"><slot name="header"></slot></header>
55-
<div part="content" id="content">
56-
<div part="message"><slot></slot></div>
53+
<header part="header"><slot name="header"></slot></header>
54+
<div part="content" id="content">
55+
<div part="message"><slot></slot></div>
56+
</div>
57+
<footer part="footer" role="toolbar">
58+
<div part="cancel-button" ?hidden="${!this.cancelButtonVisible}">
59+
<slot name="cancel-button"></slot>
5760
</div>
58-
<footer part="footer" role="toolbar">
59-
<div part="cancel-button" ?hidden="${!this.cancelButtonVisible}">
60-
<slot name="cancel-button"></slot>
61-
</div>
62-
<div part="reject-button" ?hidden="${!this.rejectButtonVisible}">
63-
<slot name="reject-button"></slot>
64-
</div>
65-
<div part="confirm-button">
66-
<slot name="confirm-button"></slot>
67-
</div>
68-
</footer>
69-
</section>
61+
<div part="reject-button" ?hidden="${!this.rejectButtonVisible}">
62+
<slot name="reject-button"></slot>
63+
</div>
64+
<div part="confirm-button">
65+
<slot name="confirm-button"></slot>
66+
</div>
67+
</footer>
7068
</div>
7169
`;
7270
}

packages/vaadin-lumo-styles/src/components/confirm-dialog-overlay.css

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,6 @@
44
* This program is available under Apache License Version 2.0, available at https://vaadin.com/license/
55
*/
66
@media lumo_components_confirm-dialog-overlay {
7-
#resizerContainer {
8-
height: 100%;
9-
}
10-
117
[part='header'] {
128
pointer-events: auto;
139
margin-inline-start: calc(var(--lumo-space-l) - var(--lumo-space-m));

0 commit comments

Comments
 (0)