Skip to content

Commit ff42c02

Browse files
authored
refactor!: update time-picker overlay to use native popover (#9755)
1 parent 4c6ec2a commit ff42c02

File tree

9 files changed

+257
-610
lines changed

9 files changed

+257
-610
lines changed

packages/combo-box/src/vaadin-combo-box-base-mixin.js

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,18 @@ export const ComboBoxBaseMixin = (superClass) =>
252252
scroller.getItemLabel = this._getItemLabel.bind(this);
253253
scroller.addEventListener('selection-changed', this._boundOverlaySelectedItemChanged);
254254

255+
this._renderScroller(scroller);
256+
257+
this._scroller = scroller;
258+
}
259+
260+
/**
261+
* Render the scroller element to the overlay.
262+
* Override to provide custom logic (e.g. setting "slot").
263+
*
264+
* @protected
265+
*/
266+
_renderScroller(scroller) {
255267
const overlay = this.$.overlay;
256268

257269
overlay.renderer = (root) => {
@@ -262,8 +274,6 @@ export const ComboBoxBaseMixin = (superClass) =>
262274

263275
// Ensure the scroller is rendered
264276
overlay.requestContentUpdate();
265-
266-
this._scroller = scroller;
267277
}
268278

269279
/**

0 commit comments

Comments
 (0)