fix: infer remote #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yuvalk
commented
May 2, 2025
yuvalk
commented
- chore(docs): add nat gateway (chore(docs): add nat gateway #33)
- fix: remove uneeded azure credential code (fix: remove uneeded azure credential code #34)
- Infer the git remote from the branch name
this is better than assuming it's called `origin` because in many cases people want to use forks on the same local directory
|
I opened a similar one here - validatedpatterns/multicloud-gitops#438 |
|
Hi @yuvalk I've approved for this, however, I think the actual change is needed here: https://github.com/validatedpatterns/common/blob/0e45daa87ca00d4f927a41ee72cfbe51270166e3/Makefile#L28 The common works by doing a pull from that repository to update. |
|
tnx, opened there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.