Skip to content

Infer the git remote from the branch name #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

Infer the git remote from the branch name #624

merged 1 commit into from
May 28, 2025

Conversation

yuvalk
Copy link
Contributor

@yuvalk yuvalk commented May 12, 2025

this is better than assuming it's called origin because in many cases
people want to use forks on the same local directory

@yuvalk
Infer the git remote from the branch name
013197f 
 this is better than assuming it's called `origin` because in many cases
 people want to use forks on the same local directory
This was referenced May 12, 2025
Merged
Closed
mbaldessari
mbaldessari reviewed May 13, 2025
View reviewed changes
Copy link
Contributor

@mbaldessari mbaldessari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. It is probably best to move the TARGET_REPO definition after TARGET_BRANCH and TARGET_ORIGIN. Makefile might be smart enough to resolve things properly, but it's best to be clearer.

@mbaldessari mbaldessari merged commit 5515ead into validatedpatterns:main May 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbaldessari mbaldessari mbaldessari left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yuvalk @mbaldessari