Quote all annotations in chart templates. #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#395 introduced a bug where booleans would not be quoted, invalidating the annotations.
willgraf
added a commit
that referenced
this pull request
Apr 6, 2021
* Update bucket-monitor helm chart with unified STORAGE_BUCKET env var. (#414) * Update copyright to 2021 (#415) * Upgrade default GKE version to 1.16 (#412) * Update autoscaler and janitor to latest release for better compatibility with 1.16. (#419) * Add new consumer and zip consumer for "multiplex" jobs. (#420) * Quote all annotations in chart templates. (#421) * Refactor multiplex consumers to mesmer consumers (#422) * Update referenced version to 1.5.0 (#423) * Bump tracking model to TensorFlow 2 based version. (#426) * Bump frontend chart to 0.3.0 and redis-consumer chart to 0.5.0 (#427)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotations must be strings! Unquoted booleans or numbers can be ignored, causing unexpected behavior. This PR updates several charts to ensure that annotations on services, ingresses, and deployments are quoted.
frontend/ingressfrontend/serviceredis-consumer/servicetf-serving/deploymenttf-serving/service